From: John Stultz <john.stultz@linaro.org>
To: Kay Sievers <kay@vrfy.org>
Cc: lkml <linux-kernel@vger.kernel.org>,
stable <stable@vger.kernel.org>, Feng Tang <feng.tang@intel.com>,
Jason Gunthorpe <jgunthorpe@obsidianresearch.com>,
Thomas Gleixner <tglx@linutronix.de>
Subject: Re: [PATCH] time: Revert ALWAYS_USE_PERSISTENT_CLOCK compile time optimizaitons
Date: Wed, 24 Apr 2013 11:55:25 -0700 [thread overview]
Message-ID: <51782A9D.20303@linaro.org> (raw)
In-Reply-To: <CAPXgP123q9K8-NibkpmbvwpRTM1cdODWycq3o-HdWEYBwoGCFQ@mail.gmail.com>
On 04/24/2013 11:41 AM, Kay Sievers wrote:
> On Wed, Apr 24, 2013 at 8:32 PM, John Stultz <john.stultz@linaro.org> wrote:
>> Kay Sievers noted that the ALWAYS_USE_PERSISTENT_CLOCK config,
>> which enables some minor compile time optimization to avoid
>> uncessary code in mostly the suspend/resume path could cause
>> problems for userland.
>>
>> In particular, the dependency for RTC_HCTOSYS on
>> !ALWAYS_USE_PERSISTENT_CLOCK, which avoids setting the time
>> twice and simplifies suspend/resume, has the side effect
>> of causing the /sys/class/rtc/rtcN/hctosys flag to always be
>> zero, and this flag is commonly used by udev to setup the
>> /dev/rtc symlink to /dev/rtcN, which can cause pain for
>> older applications.
> FWIW, in the light of the original change, I've just removed the
> /dev/rtc creation from the default udev rules now, so that thing will
> be phased out in the future.
Is that actually wanted? What happens to applications that use /dev/rtc?
I think setting up the /dev/rtc link is important. Its just that setting
it up exclusively by the hctosys flag is maybe more fragile then we'd
like. Instead the hctosys flag maybe should only be used as a hint if
there is more then one RTC available.
thanks
-john
next prev parent reply other threads:[~2013-04-24 18:55 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-24 18:32 [PATCH] time: Revert ALWAYS_USE_PERSISTENT_CLOCK compile time optimizaitons John Stultz
2013-04-24 18:41 ` Kay Sievers
2013-04-24 18:55 ` John Stultz [this message]
2013-04-24 19:18 ` Kay Sievers
2013-04-24 21:24 ` John Stultz
2013-04-25 23:22 ` Kay Sievers
2013-04-24 19:44 ` Kay Sievers
2013-04-24 21:26 ` John Stultz
2013-04-25 6:30 ` Feng Tang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51782A9D.20303@linaro.org \
--to=john.stultz@linaro.org \
--cc=feng.tang@intel.com \
--cc=jgunthorpe@obsidianresearch.com \
--cc=kay@vrfy.org \
--cc=linux-kernel@vger.kernel.org \
--cc=stable@vger.kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox