From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Message-ID: <51794990.6050405@zytor.com>
Date: Thu, 25 Apr 2013 08:19:44 -0700
From: "H. Peter Anvin" <hpa@zytor.com>
MIME-Version: 1.0
To: "Ted Ts'o" <tytso@mit.edu>
CC: Linus Torvalds <torvalds@linux-foundation.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	"H. Peter Anvin" <hpa@linux.intel.com>,
	stable <stable@vger.kernel.org>
Subject: Re: [PATCH 2/2] random: Account for entropy loss due to overwrites
References: <1366777569-23192-1-git-send-email-hpa@zytor.com> <1366777569-23192-3-git-send-email-hpa@zytor.com> <CA+55aFwkEMAkvZFdeQm2PKQD1xgFBfVa+kTwJXGmWXoDqDp7xQ@mail.gmail.com> <51794141.3070205@zytor.com> <517942AB.1010201@zytor.com>
In-Reply-To: <517942AB.1010201@zytor.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <stable.vger.kernel.org>

On this subject, I assume this is a bug?

   871
   872                  if (r->entropy_count / 8 >= nbytes + reserved)
   873                          r->entropy_count -= nbytes*8;
   874                  else
   875                          r->entropy_count = reserved;
   876

[specifically the use of "reserved" as opposed to "reserved*8" on line 875?]

	-hpa