From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Message-ID: <51A36D42.6080609@linaro.org> Date: Mon, 27 May 2013 16:27:14 +0200 From: Daniel Lezcano MIME-Version: 1.0 To: Baruch Siach CC: John Stultz , Thomas Gleixner , linux-kernel@vger.kernel.org, stable@vger.kernel.org Subject: Re: [PATCH] clocksource: dw_apb: fix error check References: <90d7cc35674bf04806531eb2e9836fdc382868d9.1369655478.git.baruch@tkos.co.il> <51A35C2F.4000201@linaro.org> <20130527134910.GU5037@tarshish> In-Reply-To: <20130527134910.GU5037@tarshish> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: On 05/27/2013 03:49 PM, Baruch Siach wrote: > Hi Daniel, > > On Mon, May 27, 2013 at 03:14:23PM +0200, Daniel Lezcano wrote: >> On 05/27/2013 01:51 PM, Baruch Siach wrote: >>> irq_of_parse_and_map() returns 0 on error, while the code checks for NO_IRQ. >>> This breaks on platforms that have NO_IRQ != 0. >>> >>> Cc: >>> Signed-off-by: Baruch Siach >>> --- >> >> Shouldn't the 'irq_of_parse_and_map' function to be fixed and return >> NO_IRQ in case of error ? (even if some code checks the return value is >> 'zero' in case of error [1], while some other code checks NO_IRQ [2]). > > Probably not. See http://lwn.net/Articles/470820/. Very interesting. Thx for the pointer ! -- Daniel -- Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog