From: Li Zefan <lizefan@huawei.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Namhyung Kim <namhyung@kernel.org>,
Frederic Weisbecker <fweisbec@gmail.com>,
Steven Rostedt <rostedt@goodmis.org>,
Ingo Molnar <mingo@kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
stable <stable@vger.kernel.org>
Subject: Re: [PATCH 3.0-stable 1/2] tracing: Fix possible NULL pointer dereferences
Date: Thu, 13 Jun 2013 09:49:03 +0800 [thread overview]
Message-ID: <51B9250F.9050704@huawei.com> (raw)
In-Reply-To: <20130610211350.GE1602@kroah.com>
On 2013/6/11 5:13, Greg Kroah-Hartman wrote:
> On Fri, Jun 07, 2013 at 05:00:33PM +0800, Li Zefan wrote:
>> commit 6a76f8c0ab19f215af2a3442870eeb5f0e81998d upstream.
>>
>> Currently set_ftrace_pid and set_graph_function files use seq_lseek
>> for their fops. However seq_open() is called only for FMODE_READ in
>> the fops->open() so that if an user tries to seek one of those file
>> when she open it for writing, it sees NULL seq_file and then panic.
>
> You lost the original authorship of this patch, which is a very bad
> thing to do.
>
Oops, my bad.
> Ugh, time to edit emails by hand, not my favorite pasttime, someone owes
> me a drink...
>
Sure, maybe at Plumber. ;)
next prev parent reply other threads:[~2013-06-13 1:49 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-07 9:00 [PATCH 3.0-stable 1/2] tracing: Fix possible NULL pointer dereferences Li Zefan
2013-06-07 9:01 ` [PATCH 3.0-stable 2/2] ftrace: Move ftrace_filter_lseek out of CONFIG_DYNAMIC_FTRACE section Li Zefan
2013-06-10 21:28 ` Patch "ftrace: Move ftrace_filter_lseek out of CONFIG_DYNAMIC_FTRACE section" has been added to the 3.0-stable tree gregkh
2013-06-10 21:13 ` [PATCH 3.0-stable 1/2] tracing: Fix possible NULL pointer dereferences Greg Kroah-Hartman
2013-06-13 1:49 ` Li Zefan [this message]
2013-06-10 21:28 ` Patch "tracing: Fix possible NULL pointer dereferences" has been added to the 3.0-stable tree gregkh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51B9250F.9050704@huawei.com \
--to=lizefan@huawei.com \
--cc=fweisbec@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=namhyung@kernel.org \
--cc=rostedt@goodmis.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox