From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Message-ID: <51EC8556.9040101@hitachi.com> Date: Mon, 22 Jul 2013 10:05:26 +0900 From: Yoshihiro YUNOMAE MIME-Version: 1.0 To: Amit Shah Cc: linux-kernel@vger.kernel.org, Arnd Bergmann , Greg Kroah-Hartman , stable@vger.kernel.org, virtualization@lists.linux-foundation.org, Hidehiro Kawai , yrl.pp-manager.tt@hitachi.com, Masami Hiramatsu Subject: Re: Re: [PATCH V2 0/2] [BUGFIX] virtio/console: Fix two bugs of splice_write References: <20130719091951.9698.95194.stgit@yunodevel> <20130719100543.GM3087@amit-x200.redhat.com> In-Reply-To: <20130719100543.GM3087@amit-x200.redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: Hi Amit, Sorry for the late reply. (2013/07/19 19:05), Amit Shah wrote: > On (Fri) 19 Jul 2013 [18:19:51], Yoshihiro YUNOMAE wrote: >> Hi, >> >> This patch set fixes two bugs of splice_write in the virtio-console driver. >> >> [BUG1] Although pipe->nrbufs is empty, the driver tries to do splice_write. >> => This induces oops in sg_init_table(). >> >> [BUG2] No lock for competition of splice_write. >> => This induces oops in splice_from_pipe_feed() by bug of any user >> application. >> >> These reports are written in each patch. >> >> Changes in V2: >> - Fix a locking problem for error >> >> Thanks! > > Reviewed-by: Amit Shah Thank you for reviewing this patch set. > For the patches to be picked up in the stable trees, you need to > include CC: in the sign-off area of the > patches, just cc'ing in the patch posting doesn't help. See > Documentation/stable_kernel_rules.txt. > > Can you submit a v3 with that change, and also add my reviewed-by > line? Sure. I'll add stable@ line, your reviewed-by line, and Masami's reviewed-by line in sign-off area for each patch. Thanks, Yoshihiro YUNOMAE -- Yoshihiro YUNOMAE Software Platform Research Dept. Linux Technology Center Hitachi, Ltd., Yokohama Research Laboratory E-mail: yoshihiro.yunomae.ez@hitachi.com