From: Joe Perches <joe@perches.com>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: Paul Burton <paulburton@google.com>,
Joel Fernandes <joelaf@google.com>,
linux-kernel@vger.kernel.org, Ingo Molnar <mingo@redhat.com>,
stable@vger.kernel.org
Subject: Re: [PATCH 1/2] tracing: Simplify & fix saved_tgids logic
Date: Thu, 01 Jul 2021 12:35:29 -0700 [thread overview]
Message-ID: <51babd56c2fe53ba011152700a546151@perches.com> (raw)
In-Reply-To: <20210701142624.44bb4dde@oasis.local.home>
On 2021-07-01 11:26, Steven Rostedt wrote:
> [ Added Joe Perches ]
>
> On Thu, 1 Jul 2021 11:12:54 -0700
> Paul Burton <paulburton@google.com> wrote:
>
>> > not to mention, we don't
>> > use '//' comments in the kernel, so that would have to be changed.
>>
>> D'oh! Apparently a year away from the kernel melted my internal style
>> checker. Interestingly though, checkpatch didn't complain about this
>> as
>> I would have expected...
>
> Joe, should the above be added to checkpatch?
>
> I do understand that there are a few cases it's acceptable. Like for
> SPDX headers.
C99 comments are allowed since about 5 years ago.
And if you really want there's a checkpatch option to disable them.
https://lore.kernel.org/patchwork/patch/1031132/
next prev parent reply other threads:[~2021-07-01 19:41 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-30 0:34 [PATCH 1/2] tracing: Simplify & fix saved_tgids logic Paul Burton
2021-06-30 0:34 ` [PATCH 2/2] tracing: Resize tgid_map to PID_MAX_LIMIT, not PID_MAX_DEFAULT Paul Burton
2021-06-30 12:35 ` Steven Rostedt
2021-06-30 21:09 ` Paul Burton
2021-06-30 21:34 ` Steven Rostedt
2021-06-30 22:34 ` Joel Fernandes
2021-06-30 23:11 ` Steven Rostedt
2021-07-01 13:55 ` Steven Rostedt
2021-07-01 17:24 ` [PATCH v2 1/2] tracing: Simplify & fix saved_tgids logic Paul Burton
2021-07-01 17:24 ` [PATCH v2 2/2] tracing: Resize tgid_map to pid_max, not PID_MAX_DEFAULT Paul Burton
2021-07-01 18:12 ` Steven Rostedt
2021-07-01 18:15 ` Paul Burton
2021-07-01 18:27 ` Steven Rostedt
2021-07-01 18:07 ` [PATCH v2 1/2] tracing: Simplify & fix saved_tgids logic Joel Fernandes
2021-06-30 12:31 ` [PATCH " Steven Rostedt
2021-06-30 16:43 ` Joel Fernandes
2021-06-30 22:29 ` Joel Fernandes
2021-07-01 17:31 ` Paul Burton
2021-07-01 18:05 ` Joel Fernandes
2021-07-01 18:07 ` Steven Rostedt
2021-07-01 18:09 ` Joel Fernandes
2021-07-01 18:12 ` Paul Burton
2021-07-01 18:26 ` Steven Rostedt
2021-07-01 19:35 ` Joe Perches [this message]
2021-07-01 19:51 ` Steven Rostedt
2021-07-01 21:07 ` Joe Perches
2021-07-01 23:49 ` Joel Fernandes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51babd56c2fe53ba011152700a546151@perches.com \
--to=joe@perches.com \
--cc=joelaf@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=paulburton@google.com \
--cc=rostedt@goodmis.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox