From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Message-ID: <521B7A5F.7030101@wwwdotorg.org> Date: Mon, 26 Aug 2013 09:55:11 -0600 From: Stephen Warren MIME-Version: 1.0 To: Colin Cross CC: Linux PM list , lkml , Neil Zhang , Joseph Lo , linux-tegra , stable@vger.kernel.org, "Rafael J. Wysocki" , Daniel Lezcano Subject: Re: [PATCH 1/3] cpuidle: coupled: disable interrupts after entering safe state References: <1377287112-12018-1-git-send-email-ccross@android.com> <5217EB9A.5050206@wwwdotorg.org> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: On 08/23/2013 06:22 PM, Colin Cross wrote: > On Fri, Aug 23, 2013 at 4:09 PM, Stephen Warren wrote: >> On 08/23/2013 01:45 PM, Colin Cross wrote: >>> Calling cpuidle_enter_state is expected to return with interrupts >>> enabled, but interrupts must be disabled before starting the >>> ready loop synchronization stage. Call local_irq_disable after >>> each call to cpuidle_enter_state for the safe state. >> >> Tested-by: Stephen Warren >> >> Note: I tested the current Tegra cpuidle code that's in next-20130819. >> IIRC, Joseph reported the issue when trying to enable some additional >> feature in Tegra30 cpuidle. I didn't actually try to enable whatever >> that was; I just briefly tested for regressions in the existing code >> configuration. > > Is that for the series or just this patch? The series.