* Re: [PATCH] ethernet/arc/arc_emac: Fix huge delays in large file copies [not found] ` <20130905.142530.732425484460470485.davem@davemloft.net> @ 2013-09-10 6:27 ` Vineet Gupta 2013-09-16 5:43 ` Vineet Gupta 0 siblings, 1 reply; 5+ messages in thread From: Vineet Gupta @ 2013-09-10 6:27 UTC (permalink / raw) To: greg Kroah-Hartman Cc: David Miller, netdev, Alexey.Brodkin, linux-kernel, arc-linux-dev, stable@vger.kernel.org On 09/05/2013 11:55 PM, David Miller wrote: > From: Vineet Gupta <Vineet.Gupta1@synopsys.com> > Date: Wed, 4 Sep 2013 17:17:15 +0530 > >> copying large files to a NFS mounted host was taking absurdly large >> time. >> >> Turns out that TX BD reclaim had a sublte bug. >> >> Loop starts off from @txbd_dirty cursor and stops when it hits a BD >> still in use by controller. However when it stops it needs to keep the >> cursor at that very BD to resume scanning in next iteration. However it >> was erroneously incrementing the cursor, causing the next scan(s) to >> fail too, unless the BD chain was completely drained out. >> >> [ARCLinux]$ ls -l -sh /disk/log.txt >> 17976 -rw-r--r-- 1 root root 17.5M Sep /disk/log.txt >> >> ========== Before ===================== >> [ARCLinux]$ time cp /disk/log.txt /mnt/. >> real 31m 7.95s >> user 0m 0.00s >> sys 0m 0.10s >> >> ========== After ===================== >> [ARCLinux]$ time cp /disk/log.txt /mnt/. >> real 0m 24.33s >> user 0m 0.00s >> sys 0m 0.19s >> >> Signed-off-by: Vineet Gupta <vgupta@synopsys.com> > > Applied. > Hi Greg, This needs a stable backport (3.11). Mainline commit 27082ee1b92f4d41e78b85 Thx, -Vineet ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] ethernet/arc/arc_emac: Fix huge delays in large file copies 2013-09-10 6:27 ` [PATCH] ethernet/arc/arc_emac: Fix huge delays in large file copies Vineet Gupta @ 2013-09-16 5:43 ` Vineet Gupta 2013-09-16 19:40 ` greg Kroah-Hartman 0 siblings, 1 reply; 5+ messages in thread From: Vineet Gupta @ 2013-09-16 5:43 UTC (permalink / raw) To: greg Kroah-Hartman Cc: David Miller, netdev, Alexey.Brodkin, linux-kernel, stable@vger.kernel.org On 09/10/2013 11:57 AM, Vineet Gupta wrote: > On 09/05/2013 11:55 PM, David Miller wrote: >> From: Vineet Gupta <Vineet.Gupta1@synopsys.com> >> Date: Wed, 4 Sep 2013 17:17:15 +0530 >> >>> copying large files to a NFS mounted host was taking absurdly large >>> time. >>> >>> Turns out that TX BD reclaim had a sublte bug. >>> >>> Loop starts off from @txbd_dirty cursor and stops when it hits a BD >>> still in use by controller. However when it stops it needs to keep the >>> cursor at that very BD to resume scanning in next iteration. However it >>> was erroneously incrementing the cursor, causing the next scan(s) to >>> fail too, unless the BD chain was completely drained out. >>> >>> [ARCLinux]$ ls -l -sh /disk/log.txt >>> 17976 -rw-r--r-- 1 root root 17.5M Sep /disk/log.txt >>> >>> ========== Before ===================== >>> [ARCLinux]$ time cp /disk/log.txt /mnt/. >>> real 31m 7.95s >>> user 0m 0.00s >>> sys 0m 0.10s >>> >>> ========== After ===================== >>> [ARCLinux]$ time cp /disk/log.txt /mnt/. >>> real 0m 24.33s >>> user 0m 0.00s >>> sys 0m 0.19s >>> >>> Signed-off-by: Vineet Gupta <vgupta@synopsys.com> >> >> Applied. >> > > Hi Greg, > > This needs a stable backport (3.11). > Mainline commit 27082ee1b92f4d41e78b85 > > Thx, > -Vineet Hi Greg, I didn't spot this one in your stable-queue for 3.11. Please apply. Thx, Vineet ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] ethernet/arc/arc_emac: Fix huge delays in large file copies 2013-09-16 5:43 ` Vineet Gupta @ 2013-09-16 19:40 ` greg Kroah-Hartman 2013-09-17 4:07 ` Vineet Gupta 0 siblings, 1 reply; 5+ messages in thread From: greg Kroah-Hartman @ 2013-09-16 19:40 UTC (permalink / raw) To: Vineet Gupta Cc: David Miller, netdev, Alexey.Brodkin, linux-kernel, stable@vger.kernel.org On Mon, Sep 16, 2013 at 11:13:48AM +0530, Vineet Gupta wrote: > On 09/10/2013 11:57 AM, Vineet Gupta wrote: > > On 09/05/2013 11:55 PM, David Miller wrote: > >> From: Vineet Gupta <Vineet.Gupta1@synopsys.com> > >> Date: Wed, 4 Sep 2013 17:17:15 +0530 > >> > >>> copying large files to a NFS mounted host was taking absurdly large > >>> time. > >>> > >>> Turns out that TX BD reclaim had a sublte bug. > >>> > >>> Loop starts off from @txbd_dirty cursor and stops when it hits a BD > >>> still in use by controller. However when it stops it needs to keep the > >>> cursor at that very BD to resume scanning in next iteration. However it > >>> was erroneously incrementing the cursor, causing the next scan(s) to > >>> fail too, unless the BD chain was completely drained out. > >>> > >>> [ARCLinux]$ ls -l -sh /disk/log.txt > >>> 17976 -rw-r--r-- 1 root root 17.5M Sep /disk/log.txt > >>> > >>> ========== Before ===================== > >>> [ARCLinux]$ time cp /disk/log.txt /mnt/. > >>> real 31m 7.95s > >>> user 0m 0.00s > >>> sys 0m 0.10s > >>> > >>> ========== After ===================== > >>> [ARCLinux]$ time cp /disk/log.txt /mnt/. > >>> real 0m 24.33s > >>> user 0m 0.00s > >>> sys 0m 0.19s > >>> > >>> Signed-off-by: Vineet Gupta <vgupta@synopsys.com> > >> > >> Applied. > >> > > > > Hi Greg, > > > > This needs a stable backport (3.11). > > Mainline commit 27082ee1b92f4d41e78b85 > > > > Thx, > > -Vineet > > Hi Greg, > > I didn't spot this one in your stable-queue for 3.11. > Please apply. Network patches for the stable tree needs to go through the networking maintainer. Please let them know about this and they will forward it on to me if needed. thanks, greg k-h ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] ethernet/arc/arc_emac: Fix huge delays in large file copies 2013-09-16 19:40 ` greg Kroah-Hartman @ 2013-09-17 4:07 ` Vineet Gupta 2013-09-17 4:17 ` David Miller 0 siblings, 1 reply; 5+ messages in thread From: Vineet Gupta @ 2013-09-17 4:07 UTC (permalink / raw) To: David Miller Cc: greg Kroah-Hartman, netdev@vger.kernel.org, Alexey.Brodkin@synopsys.com, linux-kernel@vger.kernel.org, stable@vger.kernel.org On 09/17/2013 01:10 AM, greg Kroah-Hartman wrote: > On Mon, Sep 16, 2013 at 11:13:48AM +0530, Vineet Gupta wrote: >> On 09/10/2013 11:57 AM, Vineet Gupta wrote: >>> On 09/05/2013 11:55 PM, David Miller wrote: >>>> From: Vineet Gupta <Vineet.Gupta1@synopsys.com> >>>> Date: Wed, 4 Sep 2013 17:17:15 +0530 >>>> >>>>> copying large files to a NFS mounted host was taking absurdly large >>>>> time. >>>>> >>>>> Turns out that TX BD reclaim had a sublte bug. >>>>> >>>>> Loop starts off from @txbd_dirty cursor and stops when it hits a BD >>>>> still in use by controller. However when it stops it needs to keep the >>>>> cursor at that very BD to resume scanning in next iteration. However it >>>>> was erroneously incrementing the cursor, causing the next scan(s) to >>>>> fail too, unless the BD chain was completely drained out. >>>>> >>>>> [ARCLinux]$ ls -l -sh /disk/log.txt >>>>> 17976 -rw-r--r-- 1 root root 17.5M Sep /disk/log.txt >>>>> >>>>> ========== Before ===================== >>>>> [ARCLinux]$ time cp /disk/log.txt /mnt/. >>>>> real 31m 7.95s >>>>> user 0m 0.00s >>>>> sys 0m 0.10s >>>>> >>>>> ========== After ===================== >>>>> [ARCLinux]$ time cp /disk/log.txt /mnt/. >>>>> real 0m 24.33s >>>>> user 0m 0.00s >>>>> sys 0m 0.19s >>>>> >>>>> Signed-off-by: Vineet Gupta <vgupta@synopsys.com> >>>> Applied. >>>> >>> Hi Greg, >>> >>> This needs a stable backport (3.11). >>> Mainline commit 27082ee1b92f4d41e78b85 >>> >>> Thx, >>> -Vineet >> Hi Greg, >> >> I didn't spot this one in your stable-queue for 3.11. >> Please apply. > Network patches for the stable tree needs to go through the networking > maintainer. Please let them know about this and they will forward it on > to me if needed. > > thanks, > > greg k-h Hi David, Can you please do the needful for stable 3.11 backport of this patch. Thx, -Vineet ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] ethernet/arc/arc_emac: Fix huge delays in large file copies 2013-09-17 4:07 ` Vineet Gupta @ 2013-09-17 4:17 ` David Miller 0 siblings, 0 replies; 5+ messages in thread From: David Miller @ 2013-09-17 4:17 UTC (permalink / raw) To: Vineet.Gupta1; +Cc: gregkh, netdev, Alexey.Brodkin, linux-kernel, stable From: Vineet Gupta <Vineet.Gupta1@synopsys.com> Date: Tue, 17 Sep 2013 04:07:23 +0000 > Can you please do the needful for stable 3.11 backport of this patch. Queued up for -stable. ^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2013-09-17 4:17 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <1378295235-18928-1-git-send-email-vgupta@synopsys.com>
[not found] ` <20130905.142530.732425484460470485.davem@davemloft.net>
2013-09-10 6:27 ` [PATCH] ethernet/arc/arc_emac: Fix huge delays in large file copies Vineet Gupta
2013-09-16 5:43 ` Vineet Gupta
2013-09-16 19:40 ` greg Kroah-Hartman
2013-09-17 4:07 ` Vineet Gupta
2013-09-17 4:17 ` David Miller
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).