stable.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Paolo Bonzini <pbonzini@redhat.com>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: linux-kernel@vger.kernel.org, francis.moro@gmail.com,
	kvm@vger.kernel.org, stable@vger.kernel.org
Subject: Re: [PATCH backport hints for <3.10] KVM: x86: Convert vapic synchronization to _cached functions (CVE-2013-6368)
Date: Mon, 16 Dec 2013 20:39:15 +0100	[thread overview]
Message-ID: <52AF56E3.1070404@redhat.com> (raw)
In-Reply-To: <20131216152446.GA1894@kroah.com>

Il 16/12/2013 16:24, Greg KH ha scritto:
> On Mon, Dec 16, 2013 at 12:38:17PM +0100, Paolo Bonzini wrote:
>> The KVM patch "fix vapic memory corruption" applies to most kernels that
>> have KVM, but the fix does not apply on many older branches.  The APIs it
>> uses are available in 3.1, but until 3.9 kvm_gfn_to_hva_cache_init had
>> one fewer parameter.
>>
>> The comments in this patch should help fixing kvm_lapic_set_vapic_addr
>> in older kernels.  I will review the backports as they are posted to
>> LKML (if I am CCed...).
>>
>> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
>> ---
>>  arch/x86/kvm/lapic.c | 38 +++++++++++++++++++++++++++++---------
>>  arch/x86/kvm/lapic.h |  4 ++--
>>  arch/x86/kvm/x86.c   | 33 +--------------------------------
>>  3 files changed, 32 insertions(+), 43 deletions(-)
> 
> I don't understand, what are people supposed to do with this?

If people want to backport the patch to their stable tree, and the
upstream patch doesn't apply, they can use this as a skeleton.  I was
asked by Francis how to backport the patch, and I think code is a better
tool than text.

It's not a particularly important bug.  It's okay if you don't apply it
anywhere where it doesn't apply cleanly (i.e. 3.10 and newer only), but
the Debian and RT folks may disagree.  If they want to do the backport,
I hope this can help.

Paolo

  reply	other threads:[~2013-12-16 19:39 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-12-16 11:38 [PATCH backport hints for <3.10] KVM: x86: Convert vapic synchronization to _cached functions (CVE-2013-6368) Paolo Bonzini
2013-12-16 15:24 ` Greg KH
2013-12-16 19:39   ` Paolo Bonzini [this message]
2013-12-18 17:53 ` Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=52AF56E3.1070404@redhat.com \
    --to=pbonzini@redhat.com \
    --cc=francis.moro@gmail.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=kvm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).