From: Prarit Bhargava <prarit@redhat.com>
To: linux-kernel@vger.kernel.org,
Michel Lespinasse <walken@google.com>,
Seiji Aguchi <seiji.aguchi@hds.com>,
Yang Zhang <yang.z.zhang@Intel.com>,
Paul Gortmaker <paul.gortmaker@windriver.com>,
Janet Morgan <janet.morgan@Intel.com>,
Tony Luck <tony.luck@Intel.com>, Ruiv Wang <ruiv.wang@gmail.com>,
Andi Kleen <ak@linux.intel.com>,
"H. Peter Anvin" <hpa@linux.intel.com>,
x86@kernel.org, stable@vger.kernel.org
Subject: Re: [PATCH] x86, irq, fix logical AND/OR error in check_irq_vectors_for_cpu_disable()
Date: Tue, 24 Dec 2013 08:19:09 -0500 [thread overview]
Message-ID: <52B989CD.6060403@redhat.com> (raw)
In-Reply-To: <20131224025059.GA24419@gchen.bj.intel.com>
On 12/23/2013 09:51 PM, Chen, Gong wrote:
> On Mon, Dec 23, 2013 at 09:39:12AM -0500, Prarit Bhargava wrote:
>> diff --git a/arch/x86/kernel/irq.c b/arch/x86/kernel/irq.c
>> index 7d40698..aed7acc 100644
>> --- a/arch/x86/kernel/irq.c
>> +++ b/arch/x86/kernel/irq.c
>> @@ -281,7 +281,7 @@ int check_irq_vectors_for_cpu_disable(void)
>> desc = irq_to_desc(irq);
>> data = irq_desc_get_irq_data(desc);
>> affinity = data->affinity;
>> - if (irq_has_action(irq) || !irqd_is_per_cpu(data) ||
>> + if (irq_has_action(irq) && !irqd_is_per_cpu(data) &&
>> !cpumask_subset(affinity, cpu_online_mask))
>> this_count++;
> Hi, Prarit
>
> I noticed that you don't mention another question I asked in last mail.
>
> "It looks like cpu_online_mask will be updated until cpu_disable_common
> is called, but your check_vectors is called before that."
Oh, I'm sorry ... Yes, check_irq_vectors_for_cpu_disable() is called before we
remove the CPU from the maps. If there is an error then we have to do much less
clean up of the code. I explicitly take into account the cpu that is being
downed into the check vectors code.
>
> native_cpu_disable
> cpu_disable_common
> remove_cpu_from_maps
> /*
> * until here, cpu_online_mask/cpu_online_bits
> * is cleared
> */
> set_cpu_online(cpu, false);
>
> Something I missed?
No -- are you pointing out a bug?
P.
next prev parent reply other threads:[~2013-12-24 13:19 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-23 14:39 [PATCH] x86, irq, fix logical AND/OR error in check_irq_vectors_for_cpu_disable() Prarit Bhargava
2013-12-24 2:51 ` Chen, Gong
2013-12-24 13:19 ` Prarit Bhargava [this message]
2013-12-25 2:40 ` Chen, Gong
2013-12-27 16:13 ` Prarit Bhargava
2013-12-28 1:07 ` H. Peter Anvin
2013-12-28 15:58 ` Prarit Bhargava
2013-12-27 22:01 ` H. Peter Anvin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52B989CD.6060403@redhat.com \
--to=prarit@redhat.com \
--cc=ak@linux.intel.com \
--cc=hpa@linux.intel.com \
--cc=janet.morgan@Intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=paul.gortmaker@windriver.com \
--cc=ruiv.wang@gmail.com \
--cc=seiji.aguchi@hds.com \
--cc=stable@vger.kernel.org \
--cc=tony.luck@Intel.com \
--cc=walken@google.com \
--cc=x86@kernel.org \
--cc=yang.z.zhang@Intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).