From: "H. Peter Anvin" <hpa@zytor.com>
To: Prarit Bhargava <prarit@redhat.com>, linux-kernel@vger.kernel.org
Cc: Michel Lespinasse <walken@google.com>,
Seiji Aguchi <seiji.aguchi@hds.com>,
Yang Zhang <yang.z.zhang@Intel.com>,
Paul Gortmaker <paul.gortmaker@windriver.com>,
Janet Morgan <janet.morgan@Intel.com>,
Tony Luck <tony.luck@Intel.com>, Ruiv Wang <ruiv.wang@gmail.com>,
Gong Chen <gong.chen@linux.intel.com>,
Andi Kleen <ak@linux.intel.com>,
x86@kernel.org, stable@vger.kernel.org
Subject: Re: [PATCH] x86, irq, fix logical AND/OR error in check_irq_vectors_for_cpu_disable()
Date: Fri, 27 Dec 2013 14:01:00 -0800 [thread overview]
Message-ID: <52BDF89C.3030207@zytor.com> (raw)
In-Reply-To: <1387809552-20529-1-git-send-email-prarit@redhat.com>
On 12/23/2013 06:39 AM, Prarit Bhargava wrote:
> Patch is against linux-tip.git and was tested on both linux.git and tip without
> any issues. As expected, the number of required vectors for the down'd cpu
> drops from 202 to 181 on my test system (which has 509 vectors assigned in
> total).
>
> Many thanks to Gong Chen for catching this.
>
> P.
>
> ----8<----
>
> Gong Chen caught this coding error during inspection of the patch. The
> code should be AND not OR.
>
Please include a description that is understandable by someone who isn't
familiar with the back story to this patch. The patch descriptions
become part of the permanent record of the history of the Linux kernel
and are critical to it being understandable.
-hpa
prev parent reply other threads:[~2013-12-27 22:01 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-23 14:39 [PATCH] x86, irq, fix logical AND/OR error in check_irq_vectors_for_cpu_disable() Prarit Bhargava
2013-12-24 2:51 ` Chen, Gong
2013-12-24 13:19 ` Prarit Bhargava
2013-12-25 2:40 ` Chen, Gong
2013-12-27 16:13 ` Prarit Bhargava
2013-12-28 1:07 ` H. Peter Anvin
2013-12-28 15:58 ` Prarit Bhargava
2013-12-27 22:01 ` H. Peter Anvin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52BDF89C.3030207@zytor.com \
--to=hpa@zytor.com \
--cc=ak@linux.intel.com \
--cc=gong.chen@linux.intel.com \
--cc=janet.morgan@Intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=paul.gortmaker@windriver.com \
--cc=prarit@redhat.com \
--cc=ruiv.wang@gmail.com \
--cc=seiji.aguchi@hds.com \
--cc=stable@vger.kernel.org \
--cc=tony.luck@Intel.com \
--cc=walken@google.com \
--cc=x86@kernel.org \
--cc=yang.z.zhang@Intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).