From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Message-ID: <52BDF89C.3030207@zytor.com>
Date: Fri, 27 Dec 2013 14:01:00 -0800
From: "H. Peter Anvin" <hpa@zytor.com>
MIME-Version: 1.0
To: Prarit Bhargava <prarit@redhat.com>, linux-kernel@vger.kernel.org
CC: Michel Lespinasse <walken@google.com>,
	Seiji Aguchi <seiji.aguchi@hds.com>,
	Yang Zhang <yang.z.zhang@Intel.com>,
	Paul Gortmaker <paul.gortmaker@windriver.com>,
	Janet Morgan <janet.morgan@Intel.com>,
	Tony Luck <tony.luck@Intel.com>,
	Ruiv Wang <ruiv.wang@gmail.com>,
	Gong Chen <gong.chen@linux.intel.com>,
	Andi Kleen <ak@linux.intel.com>, x86@kernel.org,
	stable@vger.kernel.org
Subject: Re: [PATCH] x86, irq, fix logical AND/OR error in check_irq_vectors_for_cpu_disable()
References: <1387809552-20529-1-git-send-email-prarit@redhat.com>
In-Reply-To: <1387809552-20529-1-git-send-email-prarit@redhat.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <stable.vger.kernel.org>

On 12/23/2013 06:39 AM, Prarit Bhargava wrote:
> Patch is against linux-tip.git and was tested on both linux.git and tip without
> any issues.  As expected, the number of required vectors for the down'd cpu
> drops from 202 to 181 on my test system (which has 509 vectors assigned in
> total).
> 
> Many thanks to Gong Chen for catching this.
> 
> P.
> 
> ----8<----
> 
> Gong Chen caught this coding error during inspection of the patch.  The
> code should be AND not OR.
> 

Please include a description that is understandable by someone who isn't
familiar with the back story to this patch.  The patch descriptions
become part of the permanent record of the history of the Linux kernel
and are critical to it being understandable.

	-hpa