From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Message-ID: <52EA300C.8020807@redhat.com> Date: Thu, 30 Jan 2014 11:57:16 +0100 From: Paolo Bonzini MIME-Version: 1.0 To: Dan Carpenter , Gleb Natapov CC: kvm@vger.kernel.org, kernel-janitors@vger.kernel.org, stable Subject: Re: [patch] KVM: return an error code in kvm_vm_ioctl_register_coalesced_mmio() References: <20140129131639.GB10678@elgon.mountain> In-Reply-To: <20140129131639.GB10678@elgon.mountain> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: kvm-owner@vger.kernel.org List-ID: Il 29/01/2014 14:16, Dan Carpenter ha scritto: > If kvm_io_bus_register_dev() fails then it returns success but it should > return an error code. > > I also did a little cleanup like removing an impossible NULL test. > > Fixes: 2b3c246a682c ('KVM: Make coalesced mmio use a device per zone') > Signed-off-by: Dan Carpenter > > diff --git a/virt/kvm/coalesced_mmio.c b/virt/kvm/coalesced_mmio.c > index 88b2fe3ddf42..00d86427af0f 100644 > --- a/virt/kvm/coalesced_mmio.c > +++ b/virt/kvm/coalesced_mmio.c > @@ -154,17 +154,13 @@ int kvm_vm_ioctl_register_coalesced_mmio(struct kvm *kvm, > list_add_tail(&dev->list, &kvm->coalesced_zones); > mutex_unlock(&kvm->slots_lock); > > - return ret; > + return 0; > > out_free_dev: > mutex_unlock(&kvm->slots_lock); > - > kfree(dev); > > - if (dev == NULL) > - return -ENXIO; > - > - return 0; > + return ret; > } > > int kvm_vm_ioctl_unregister_coalesced_mmio(struct kvm *kvm, > Applying to kvm/master, and adding a "Cc: stable@vger.kernel.org" while at it. Paolo