Re: [PATCH] ASoC: cs42l43-jack: Remove manual pm_runtime get/put from tip_sense_work

["Péter Ujfalusi" <peter.ujfalusi@linux.intel.com>]

On 17/03/2026 08:21, Péter Ujfalusi wrote:
>> Fundamentally reseting a device right before checking what state
>> it was in is always going to be hard, so would be awesome if you
>> could have a look at how much of a problem removing that bus
>> reset would be.
> 
> I'm still not sure if I get the whole picture, but by the hints it looks
> like that on systems with cs42l43 we cannot suspend the DSP since the
> codec cannot be suspended?
> What is the difference between detecting the jack insert compared to
> detecting the jack removal and/or the HS button detection?
> Under the hood it is the same soundwire wake event then do what needs to
> be done to read the cause of the event, right?
> So, why it is OK to suspend the DSP when the jack is not inserted and it
> is not OK if it is inserted?

Using UI shows what you might be referring to.
with the codec powered on and pressing the button:
snd_soc_cs42l43:cs42l43_button_press: cs42l43-codec cs42l43-codec:
Detected button 0 at 8 Ohms
...
snd_soc_cs42l43:cs42l43_button_release: cs42l43-codec cs42l43-codec:
Button release IRQ

when the codec and DSP suspends when audio is idle:
snd_soc_cs42l43:cs42l43_stop_button_detect: cs42l43-codec cs42l43-codec:
Stop button detect
...
snd_soc_cs42l43:cs42l43_start_button_detect: cs42l43-codec
cs42l43-codec: Start button detect
...
snd_soc_cs42l43:cs42l43_button_press: cs42l43-codec cs42l43-codec:
Button ignored due to bias sense
...
snd_soc_cs42l43:cs42l43_button_release: cs42l43-codec cs42l43-codec:
Button release IRQ

and the first button press is ignored  - which wakes the DSP, soundwire
and codec up

So yes, there seams to be an issue with the headset button handling here.

> 
>>> Even then there is the issue of unbalance in runtime get on module
>>> removal when the jack is connected...
>>
>> Yeah that is a good spot, if we stick with the current code I
>> will get that fixed up.
>>
>> Thanks,
>> Charles
> 

-- 
Péter