From: Dirk Brandewie <dirk.brandewie@gmail.com>
To: Stefan Lippers-Hollmann <s.L-H@gmx.de>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: dirk.j.brandewie@intel.com, linux-kernel@vger.kernel.org,
stable@vger.kernel.org,
"Rafael J. Wysocki" <rafael.j.wysocki@intel.com>,
Romain Francoise <romain@orebokech.com>
Subject: Re: [PATCH 3.13 39/40] intel_pstate: Take core C0 time into account for core busy calculation
Date: Wed, 19 Feb 2014 08:41:46 -0800 [thread overview]
Message-ID: <5304DECA.8050605@intel.com> (raw)
In-Reply-To: <201402191252.45466.s.L-H@gmx.de>
On 02/19/2014 04:52 AM, Stefan Lippers-Hollmann wrote:
> Hi
>
> On Tuesday 18 February 2014, Greg Kroah-Hartman wrote:
>> 3.13-stable review patch. If anyone has any objections, please let me know.
>>
>> ------------------
>>
>> From: Dirk Brandewie <dirk.j.brandewie@intel.com>
>>
>> commit fcb6a15c2e7e76d493e6f91ea889ab40e1c643a4 upstream.
>>
>> Take non-idle time into account when calculating core busy time.
>> This ensures that intel_pstate will notice a decrease in load.
>>
>> References: https://bugzilla.kernel.org/show_bug.cgi?id=66581
>> Cc: 3.10+ <stable@vger.kernel.org> # 3.10+
>> Signed-off-by: Dirk Brandewie <dirk.j.brandewie@intel.com>
>> Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
>> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
>
> This patch, as part of v3.13.4-rc1 causes a kernel package very early
> during the boot on at least sandy-bridge (H67) and ivy-bridge (H77),
> the call trace (slightly cut on top, as it doesn't fit on the screen;
> copied by hand - so it might contains typos, especially in the
> heaxdecimal values) is:
>
Somehow I fat fingered it and sent an incomplete patch :-(
A replacement is on the way.
--Dirk
> RDX: 0000000000000000 RSI: 0000000000006000 RDI: 0000000000002200
> RBP: 00000009efce4c2b R08: 0000000a3e90e95c R09: 0000000000017700
> R10: 0000000000000026 R11: 000000000000002a R12: 0000000000000000
> R13: ffff880408ac4c2b R14: ffff88041f20c388 R15: 0000000000000000
> FS: 0000000000000000(0000) GS:ffff88041f200000(0000) knlGS:0000000000000000
> CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033
> CR2: fff88041f5ff000 CR3: 000000000d510000 CR4: 00000000000407f0
> Stack:
> 00000000fffffffd ffff880408ac4a00 ffff880408ac4800 ffffffff81294b82
> ffff880408ac4800 0000000000000000 0000000000000000 0000000000000000
> ffffffff812925b3 0000000000000011 ffffffff81578e70 ffff880408ca9de8
> Call Trace:
> [<ffffffff81294b82>] ? intel_pstate_cpu_init+0x107/0x1c2
> [<ffffffff812925b3>] ? __cpufreq_add_dev.isra.23+0x30c/0x676
> [<ffffffff81269174>] ? subsys_interface_register+0xab/0xdf
> [<ffffffff8106d2df>] ? arch_local_irq_save+0x11/0x17
> [<ffffffff81291279>] ? cpufreq_register_driver+0x9e/0x143
> [<ffffffff8129438d>] ? core_get_min_pstate+0x19/0x19
> [<ffffffff815df06e>] ? intel_pstate_init+0x269/0x397
> [<ffffffff815dee05>] ? intel_pstate_setup+0x29/0x29
> [<ffffffff810020da>] ? do_one_initcall+0x88/0x123
> [<ffffffff81057794>] ? parse_args+0x182/0x236
> [<ffffffff815adee1>] ? kernel_init_freeable+0x183/0x208
> [<ffffffff815ad721>] ? do_early_param+0x81/0x81
> [<ffffffff8136d288>] ? rest_init+0x7c/0x7c
> [<ffffffff8136d28d>] ? kernel_init+0x5/0xfa
> [<ffffffff8137e1cc>] ? ret_from_fork+0x7c/0x7c
> [<ffffffff8136d288>] ? rest_init+0x7c/0x7c
> Code: 00 48 6b 41 08 64 48 8b 79 10 49 c1 e1 08 48 f7 f7 31 d2 48 89 c6 48 6b c7 64 49 63 f9 4c 69 ce e8 03 00 00 48 c1 e6 08 48 63 f6 <48> f7 71 18 49 c1 e1 09 4d 63 c9 49 0f af f9 48 8d 50 01 48 c1
> RIP [<ffffffff812947c4>] intel_pstate_sample+0xb6/0x104
> RSP <ffff880408ca9d28>
> ---[ end trace 682f24c8e98de9df ]---
> Kernel panic - not syncing: Attempted to kill init! exitcode=0x0000000b
>
> Reverting just this patch from 3.13.4-rc1 fixes the regression.
>
> Regards
> Stefan Lippers-Hollmann
>
next prev parent reply other threads:[~2014-02-19 16:41 UTC|newest]
Thread overview: 56+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-18 22:47 [PATCH 3.13 00/40] 3.13.4-stable review Greg Kroah-Hartman
2014-02-18 22:47 ` [PATCH 3.13 01/40] SELinux: Fix kernel BUG on empty security contexts Greg Kroah-Hartman
2014-02-18 22:47 ` [PATCH 3.13 02/40] Btrfs: disable snapshot aware defrag for now Greg Kroah-Hartman
2014-02-18 22:47 ` [PATCH 3.13 03/40] crypto: s390 - fix concurrency issue in aes-ctr mode Greg Kroah-Hartman
2014-02-18 22:47 ` [PATCH 3.13 04/40] crypto: s390 - fix des and des3_ede cbc concurrency issue Greg Kroah-Hartman
2014-02-18 22:47 ` [PATCH 3.13 05/40] crypto: s390 - fix des and des3_ede ctr " Greg Kroah-Hartman
2014-02-18 22:47 ` [PATCH 3.13 06/40] NFSv4.1: nfs4_destroy_session must call rpc_destroy_waitqueue Greg Kroah-Hartman
2014-02-18 22:47 ` [PATCH 3.13 07/40] NFSv4: Fix memory corruption in nfs4_proc_open_confirm Greg Kroah-Hartman
2014-02-18 22:47 ` [PATCH 3.13 08/40] regulator: core: Correct default return value for full constraints Greg Kroah-Hartman
2014-02-18 22:47 ` [PATCH 3.13 09/40] irqchip: armada-370-xp: fix IPI race condition Greg Kroah-Hartman
2014-02-18 22:47 ` [PATCH 3.13 10/40] irqchip: armada-370-xp: fix MSI " Greg Kroah-Hartman
2014-02-18 22:47 ` [PATCH 3.13 11/40] arm64: vdso: update wtm fields for CLOCK_MONOTONIC_COARSE Greg Kroah-Hartman
2014-02-18 22:47 ` [PATCH 3.13 12/40] arm64: atomics: fix use of acquire + release for full barrier semantics Greg Kroah-Hartman
2014-02-18 22:47 ` [PATCH 3.13 13/40] arm64: vdso: prevent ld from aligning PT_LOAD segments to 64k Greg Kroah-Hartman
2014-02-18 22:47 ` [PATCH 3.13 14/40] arm64: Invalidate the TLB when replacing pmd entries during boot Greg Kroah-Hartman
2014-02-18 22:47 ` [PATCH 3.13 15/40] arm64: vdso: fix coarse clock handling Greg Kroah-Hartman
2014-02-18 22:47 ` [PATCH 3.13 16/40] arm64: add DSB after icache flush in __flush_icache_all() Greg Kroah-Hartman
2014-02-18 22:47 ` [PATCH 3.13 17/40] ALSA: usb-audio: Add missing kconfig dependecy Greg Kroah-Hartman
2014-02-18 22:47 ` [PATCH 3.13 18/40] ALSA: hda - Fix missing VREF setup for Mac Pro 1,1 Greg Kroah-Hartman
2014-02-18 22:47 ` [PATCH 3.13 19/40] ALSA: hda - Fix silent output on Toshiba Satellite L40 Greg Kroah-Hartman
2014-02-18 22:47 ` [PATCH 3.13 20/40] ALSA: hda - Add missing mixer widget for AD1983 Greg Kroah-Hartman
2014-02-18 22:47 ` [PATCH 3.13 21/40] ALSA: hda - Improve loopback path lookups " Greg Kroah-Hartman
2014-02-18 22:47 ` [PATCH 3.13 22/40] mm/swap: fix race on swap_info reuse between swapoff and swapon Greg Kroah-Hartman
2014-02-18 22:47 ` [PATCH 3.13 23/40] mm: __set_page_dirty_nobuffers() uses spin_lock_irqsave() instead of spin_lock_irq() Greg Kroah-Hartman
2014-02-18 22:47 ` [PATCH 3.13 24/40] mm: __set_page_dirty uses spin_lock_irqsave instead of spin_lock_irq Greg Kroah-Hartman
2014-02-18 22:47 ` [PATCH 3.13 25/40] x86: mm: change tlb_flushall_shift for IvyBridge Greg Kroah-Hartman
2014-02-18 22:47 ` [PATCH 3.13 26/40] [media] af9035: add ID [2040:f900] Hauppauge WinTV-MiniStick 2 Greg Kroah-Hartman
2014-02-18 22:47 ` [PATCH 3.13 27/40] [media] mxl111sf: Fix unintentional garbage stack read Greg Kroah-Hartman
2014-02-18 22:47 ` [PATCH 3.13 29/40] [media] Revert "[media] videobuf_vm_{open,close} race fixes" Greg Kroah-Hartman
2014-02-18 22:47 ` [PATCH 3.13 30/40] [media] cx24117: use a valid dev pointer for dev_err printout Greg Kroah-Hartman
2014-02-18 22:47 ` [PATCH 3.13 31/40] x86, hweight: Fix BUG when booting with CONFIG_GCOV_PROFILE_ALL=y Greg Kroah-Hartman
2014-02-18 22:47 ` [PATCH 3.13 32/40] genirq: Generic irq chip requires IRQ_DOMAIN Greg Kroah-Hartman
2014-02-18 22:47 ` [PATCH 3.13 33/40] pinctrl: at91: use locked variant of irq_set_handler Greg Kroah-Hartman
2014-02-18 22:47 ` [PATCH 3.13 34/40] pinctrl: imx27: fix wrong offset to ICONFB Greg Kroah-Hartman
2014-02-18 22:47 ` [PATCH 3.13 35/40] pinctrl: imx27: fix offset calculation in imx_read_2bit Greg Kroah-Hartman
2014-02-18 22:47 ` [PATCH 3.13 36/40] pinctrl: vt8500: Change devicetree data parsing Greg Kroah-Hartman
2014-02-18 22:47 ` [PATCH 3.13 37/40] pinctrl: protect pinctrl_list add Greg Kroah-Hartman
2014-02-18 22:47 ` [PATCH 3.13 38/40] bcache: fix BUG_ON due to integer overflow with GC_SECTORS_USED Greg Kroah-Hartman
2014-02-18 22:47 ` [PATCH 3.13 39/40] intel_pstate: Take core C0 time into account for core busy calculation Greg Kroah-Hartman
2014-02-19 12:52 ` Stefan Lippers-Hollmann
2014-02-19 16:41 ` Dirk Brandewie [this message]
2014-02-18 22:47 ` [PATCH 3.13 40/40] ARM: imx6: Initialize low-power mode early again Greg Kroah-Hartman
2014-02-19 4:30 ` [PATCH 3.13 00/40] 3.13.4-stable review Guenter Roeck
2014-02-20 18:32 ` Greg Kroah-Hartman
2014-02-20 23:23 ` Guenter Roeck
2014-02-20 23:32 ` Greg Kroah-Hartman
2014-02-21 2:49 ` Guenter Roeck
2014-02-20 0:16 ` Shuah Khan
2014-02-20 0:36 ` Mark Brown
2014-02-20 1:20 ` Shuah Khan
2014-02-20 2:34 ` Mark Brown
2014-02-20 13:40 ` Shuah Khan
2014-02-20 14:45 ` Mark Brown
2014-02-20 18:29 ` Greg Kroah-Hartman
2014-02-20 10:26 ` Satoru Takeuchi
2014-02-20 18:31 ` Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5304DECA.8050605@intel.com \
--to=dirk.brandewie@gmail.com \
--cc=dirk.j.brandewie@intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rafael.j.wysocki@intel.com \
--cc=romain@orebokech.com \
--cc=s.L-H@gmx.de \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).