From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Message-id: <5317A52E.4@samsung.com> Date: Wed, 05 Mar 2014 15:29:02 -0700 From: Shuah Khan Reply-to: shuah.kh@samsung.com MIME-version: 1.0 To: Joe Perches Cc: lgirdwood@gmail.com, broonie@kernel.org, gregkh@linuxfoundation.org, stable@vger.kernel.org, linux-kernel@vger.kernel.org, shuahkhan@gmail.com, Mark Brown , Shuah Khan , "shuahkhan@gmail.com" Subject: Re: [PATCH 3.13] regulator: core: Change dummy supplies error message to a warning References: <1394054987-4743-1-git-send-email-shuah.kh@samsung.com> <1394056859.12070.23.camel@joe-AO722> In-reply-to: <1394056859.12070.23.camel@joe-AO722> Content-type: text/plain; charset=ISO-8859-1; format=flowed Content-transfer-encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: On 03/05/2014 03:00 PM, Joe Perches wrote: > On Wed, 2014-03-05 at 14:29 -0700, Shuah Khan wrote: >> Change "dummy supplies not allowed" error message to warning instead, >> as this is a just warning message with no change to the behavior. > [] >> diff --git a/drivers/regulator/core.c b/drivers/regulator/core.c > [] >> @@ -1359,7 +1359,7 @@ static struct regulator *_regulator_get(struct device *dev, const char *id, >> rdev = dummy_regulator_rdev; >> goto found; >> } else { >> - dev_err(dev, "dummy supplies not allowed\n"); >> + dev_warn(dev, "dummy supplies not allowed\n"); > > What does this mean anyway? > > Would it be better to emit the calling function too with > %pf, __builtin_return_address(0)? > Maybe. In that case, that change has to first go into the mainline. This is a back port of an upstream commit to get rid of a regression in error messages. -- Shuah -- Shuah Khan Senior Linux Kernel Developer - Open Source Group Samsung Research America(Silicon Valley) shuah.kh@samsung.com | (970) 672-0658