* [PATCH 3.13] regulator: core: Change dummy supplies error message to a warning
@ 2014-03-05 21:29 Shuah Khan
2014-03-05 22:00 ` Joe Perches
2014-03-19 23:58 ` Greg KH
0 siblings, 2 replies; 6+ messages in thread
From: Shuah Khan @ 2014-03-05 21:29 UTC (permalink / raw)
To: lgirdwood, broonie, gregkh
Cc: Shuah Khan, stable, linux-kernel, shuahkhan, Mark Brown
Change "dummy supplies not allowed" error message to warning instead,
as this is a just warning message with no change to the behavior.
upstream commit acc3d5cec84f82ebea535fa0bd9500ac3df2aee9
Signed-off-by: Shuah Khan <shuah.kh@samsung.com>
Signed-off-by: Mark Brown <broonie@linaro.org>
---
Back porting as the original patch tagged for stable failed to apply.
Included Mark Brown's Signed-off from the original commit. This change
is not applicable to 3.12 and earlier.
drivers/regulator/core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/regulator/core.c b/drivers/regulator/core.c
index 0186c1b..804521a 100644
--- a/drivers/regulator/core.c
+++ b/drivers/regulator/core.c
@@ -1359,7 +1359,7 @@ static struct regulator *_regulator_get(struct device *dev, const char *id,
rdev = dummy_regulator_rdev;
goto found;
} else {
- dev_err(dev, "dummy supplies not allowed\n");
+ dev_warn(dev, "dummy supplies not allowed\n");
}
mutex_unlock(®ulator_list_mutex);
--
1.7.10.4
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH 3.13] regulator: core: Change dummy supplies error message to a warning
2014-03-05 21:29 [PATCH 3.13] regulator: core: Change dummy supplies error message to a warning Shuah Khan
@ 2014-03-05 22:00 ` Joe Perches
2014-03-05 22:29 ` Shuah Khan
2014-03-19 23:58 ` Greg KH
1 sibling, 1 reply; 6+ messages in thread
From: Joe Perches @ 2014-03-05 22:00 UTC (permalink / raw)
To: Shuah Khan
Cc: lgirdwood, broonie, gregkh, stable, linux-kernel, shuahkhan,
Mark Brown
On Wed, 2014-03-05 at 14:29 -0700, Shuah Khan wrote:
> Change "dummy supplies not allowed" error message to warning instead,
> as this is a just warning message with no change to the behavior.
[]
> diff --git a/drivers/regulator/core.c b/drivers/regulator/core.c
[]
> @@ -1359,7 +1359,7 @@ static struct regulator *_regulator_get(struct device *dev, const char *id,
> rdev = dummy_regulator_rdev;
> goto found;
> } else {
> - dev_err(dev, "dummy supplies not allowed\n");
> + dev_warn(dev, "dummy supplies not allowed\n");
What does this mean anyway?
Would it be better to emit the calling function too with
%pf, __builtin_return_address(0)?
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH 3.13] regulator: core: Change dummy supplies error message to a warning
2014-03-05 22:00 ` Joe Perches
@ 2014-03-05 22:29 ` Shuah Khan
0 siblings, 0 replies; 6+ messages in thread
From: Shuah Khan @ 2014-03-05 22:29 UTC (permalink / raw)
To: Joe Perches
Cc: lgirdwood, broonie, gregkh, stable, linux-kernel, shuahkhan,
Mark Brown, Shuah Khan, shuahkhan@gmail.com
On 03/05/2014 03:00 PM, Joe Perches wrote:
> On Wed, 2014-03-05 at 14:29 -0700, Shuah Khan wrote:
>> Change "dummy supplies not allowed" error message to warning instead,
>> as this is a just warning message with no change to the behavior.
> []
>> diff --git a/drivers/regulator/core.c b/drivers/regulator/core.c
> []
>> @@ -1359,7 +1359,7 @@ static struct regulator *_regulator_get(struct device *dev, const char *id,
>> rdev = dummy_regulator_rdev;
>> goto found;
>> } else {
>> - dev_err(dev, "dummy supplies not allowed\n");
>> + dev_warn(dev, "dummy supplies not allowed\n");
>
> What does this mean anyway?
>
> Would it be better to emit the calling function too with
> %pf, __builtin_return_address(0)?
>
Maybe. In that case, that change has to first go into the mainline. This
is a back port of an upstream commit to get rid of a regression in error
messages.
-- Shuah
--
Shuah Khan
Senior Linux Kernel Developer - Open Source Group
Samsung Research America(Silicon Valley)
shuah.kh@samsung.com | (970) 672-0658
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 3.13] regulator: core: Change dummy supplies error message to a warning
2014-03-05 21:29 [PATCH 3.13] regulator: core: Change dummy supplies error message to a warning Shuah Khan
2014-03-05 22:00 ` Joe Perches
@ 2014-03-19 23:58 ` Greg KH
2014-03-20 10:02 ` Mark Brown
1 sibling, 1 reply; 6+ messages in thread
From: Greg KH @ 2014-03-19 23:58 UTC (permalink / raw)
To: Shuah Khan
Cc: lgirdwood, broonie, stable, linux-kernel, shuahkhan, Mark Brown
On Wed, Mar 05, 2014 at 02:29:47PM -0700, Shuah Khan wrote:
> Change "dummy supplies not allowed" error message to warning instead,
> as this is a just warning message with no change to the behavior.
>
> upstream commit acc3d5cec84f82ebea535fa0bd9500ac3df2aee9
>
> Signed-off-by: Shuah Khan <shuah.kh@samsung.com>
> Signed-off-by: Mark Brown <broonie@linaro.org>
> ---
>
> Back porting as the original patch tagged for stable failed to apply.
> Included Mark Brown's Signed-off from the original commit. This change
> is not applicable to 3.12 and earlier.
>
> drivers/regulator/core.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/regulator/core.c b/drivers/regulator/core.c
> index 0186c1b..804521a 100644
> --- a/drivers/regulator/core.c
> +++ b/drivers/regulator/core.c
> @@ -1359,7 +1359,7 @@ static struct regulator *_regulator_get(struct device *dev, const char *id,
> rdev = dummy_regulator_rdev;
> goto found;
> } else {
> - dev_err(dev, "dummy supplies not allowed\n");
> + dev_warn(dev, "dummy supplies not allowed\n");
This really isn't a problem that warrents a stable backport, sorry. I
can understand distros being "annoyed" at it, but probably not.
greg k-h
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH 3.13] regulator: core: Change dummy supplies error message to a warning
2014-03-19 23:58 ` Greg KH
@ 2014-03-20 10:02 ` Mark Brown
2014-03-20 21:16 ` Greg KH
0 siblings, 1 reply; 6+ messages in thread
From: Mark Brown @ 2014-03-20 10:02 UTC (permalink / raw)
To: Greg KH; +Cc: Shuah Khan, lgirdwood, stable, linux-kernel, shuahkhan
[-- Attachment #1: Type: text/plain, Size: 505 bytes --]
On Wed, Mar 19, 2014 at 11:58:28PM +0000, Greg KH wrote:
> On Wed, Mar 05, 2014 at 02:29:47PM -0700, Shuah Khan wrote:
> > - dev_err(dev, "dummy supplies not allowed\n");
> > + dev_warn(dev, "dummy supplies not allowed\n");
> This really isn't a problem that warrents a stable backport, sorry. I
> can understand distros being "annoyed" at it, but probably not.
A previous stable commit caused this to happen for esentially every
regulator request on x86 when previously it wouldn't have triggered.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 3.13] regulator: core: Change dummy supplies error message to a warning
2014-03-20 10:02 ` Mark Brown
@ 2014-03-20 21:16 ` Greg KH
0 siblings, 0 replies; 6+ messages in thread
From: Greg KH @ 2014-03-20 21:16 UTC (permalink / raw)
To: Mark Brown; +Cc: Shuah Khan, lgirdwood, stable, linux-kernel, shuahkhan
On Thu, Mar 20, 2014 at 10:02:41AM +0000, Mark Brown wrote:
> On Wed, Mar 19, 2014 at 11:58:28PM +0000, Greg KH wrote:
> > On Wed, Mar 05, 2014 at 02:29:47PM -0700, Shuah Khan wrote:
>
> > > - dev_err(dev, "dummy supplies not allowed\n");
> > > + dev_warn(dev, "dummy supplies not allowed\n");
>
> > This really isn't a problem that warrents a stable backport, sorry. I
> > can understand distros being "annoyed" at it, but probably not.
>
> A previous stable commit caused this to happen for esentially every
> regulator request on x86 when previously it wouldn't have triggered.
Ick, ok, fair enough, I'll queue it up, thanks.
greg k-h
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2014-03-20 21:16 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-03-05 21:29 [PATCH 3.13] regulator: core: Change dummy supplies error message to a warning Shuah Khan
2014-03-05 22:00 ` Joe Perches
2014-03-05 22:29 ` Shuah Khan
2014-03-19 23:58 ` Greg KH
2014-03-20 10:02 ` Mark Brown
2014-03-20 21:16 ` Greg KH
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).