From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: Roger Quadros <rogerq@ti.com>, balbi@ti.com
Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
"3.9+" <stable@vger.kernel.org>,
Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Subject: Re: [PATCH] usb: gadget: zero: Fix SuperSpeed enumeration for alternate setting 1
Date: Wed, 26 Mar 2014 17:06:16 +0400 [thread overview]
Message-ID: <5332D0C8.5040300@cogentembedded.com> (raw)
In-Reply-To: <1395826086-5097-1-git-send-email-rogerq@ti.com>
Hello.
On 26-03-2014 13:28, Roger Quadros wrote:
> It was impossible to enumerate on a SuperSpeed (XHCI) host
> with alternate setting = 1 due to the wrongly set 'bMaxBurst'
> field in the SuperSpeed Endpoint Companion descriptor.
> Testcase:
> <host> modprobe -r usbtest; modprobe usbtest alt=1
> <device> modprobe g_zero
> plug device to SuperSpeed port on the host.
> Without this patch the host always complains like so
> "usb 12-2: Not enough bandwidth for new device state.
> usb 12-2: Not enough bandwidth for altsetting 1"
> Bug was introduced by commit cf9a08ae in v3.9
Please also specify that commit's summary in parens. Also, there's now an
adopted standard way of saying this:
Fixes: <12-digit SHA ID> ("<summary line>")
> Cc: 3.9+ <stable@vger.kernel.org> # 3.9+
> Cc: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
> Reviewed-by: Felipe Balbi <balbi@ti.com>
> Signed-off-by: Roger Quadros <rogerq@ti.com>
WBR, Sergei
next prev parent reply other threads:[~2014-03-26 13:06 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-26 9:28 [PATCH] usb: gadget: zero: Fix SuperSpeed enumeration for alternate setting 1 Roger Quadros
2014-03-26 10:50 ` Sebastian Andrzej Siewior
2014-03-26 13:06 ` Sergei Shtylyov [this message]
2014-03-26 14:42 ` Roger Quadros
2014-03-26 16:46 ` [PATCH v2] " Roger Quadros
2014-04-22 12:28 ` Roger Quadros
2014-04-22 12:35 ` Roger Quadros
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5332D0C8.5040300@cogentembedded.com \
--to=sergei.shtylyov@cogentembedded.com \
--cc=balbi@ti.com \
--cc=bigeasy@linutronix.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=rogerq@ti.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).