From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Message-ID: <5339D096.4040302@suse.cz> Date: Mon, 31 Mar 2014 22:31:18 +0200 From: Michal Marek MIME-Version: 1.0 To: Alexander Holler , linux-kernel@vger.kernel.org CC: Andrew Morton , Levente Kurusa , stable@vger.kernel.org Subject: Re: [PATCH 2/2 v3] initramfs: print error and shell out for unsupported content References: <532CC625.7020509@ahsoftware.de> <1395491361-28069-1-git-send-email-holler@ahsoftware.de> <1395491361-28069-2-git-send-email-holler@ahsoftware.de> <532DD4E7.3070706@ahsoftware.de> In-Reply-To: <532DD4E7.3070706@ahsoftware.de> Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: Dne 22.3.2014 19:22, Alexander Holler napsal(a): > Am 22.03.2014 13:29, schrieb Alexander Holler: >> The initramfs generation is broken for file and directory names which >> contain >> colons, spaces and other unusual characters. Print an error and don't >> try to >> continue. > > (...) >> + # Files and directories with spaces and colons are unsupported. >> + local unsupported=$(find "${srcdir}" -regex '.*\(:\| >> \|\n\|\r\|\t\).*') > > I've just noted that -regex isn't POSIX. I don't know the kernel rules > regarding this, and I don't care. But it might be a blocker for this patch. The bigger problem is that there is no C-style quoting in regexps or character classes matches any file with 'n', 'r' or 't' in its name. How about -name '*[:[:space:]]*' ? Michal