From: "H. Peter Anvin" <hpa@zytor.com>
To: "Thomas Bächler" <thomas@archlinux.org>, tj@kernel.org
Cc: d@falconindy.com, linux-kernel@vger.kernel.org,
gregkh@linuxfoundation.org, P@draigbrady.com,
alexandre.f.demers@gmail.com, "3.14" <stable@vger.kernel.org>
Subject: Re: [PATCH] fs: Don't return 0 from get_anon_bdev
Date: Thu, 03 Apr 2014 13:21:32 -0700 [thread overview]
Message-ID: <533DC2CC.5090408@zytor.com> (raw)
In-Reply-To: <1396554595-11796-1-git-send-email-thomas@archlinux.org>
On 04/03/2014 12:49 PM, Thomas Bächler wrote:
> Commit 9e30cc9595303b27b48 removed an internal mount. This
> has the side-effect that rootfs now has FSID 0. Many
> userspace utilities assume that st_dev in struct stat
> is never 0, so this change breaks a number of tools in
> early userspace.
>
> Since we don't know how many userspace programs are affected,
> make sure that FSID is at least 1.
>
> References: http://article.gmane.org/gmane.linux.kernel/1666905
> References: http://permalink.gmane.org/gmane.linux.utilities.util-linux-ng/8557
> Cc: 3.14 <stable@vger.kernel.org>
> Signed-off-by: Thomas Bächler <thomas@archlinux.org>
> ---
> fs/super.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
Acked-by: H. Peter Anvin <hpa@zytor.com>
It is worth noting that zero has been documented as a null device number
since at least 1995, probably more like 1993.
-hpa
next prev parent reply other threads:[~2014-04-03 20:21 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20140403191617.GB2472@mtj.dyndns.org>
2014-04-03 19:49 ` [PATCH] fs: Don't return 0 from get_anon_bdev Thomas Bächler
2014-04-03 19:51 ` Tejun Heo
2014-04-03 19:55 ` [PATCHv2] " Thomas Bächler
2014-04-03 20:32 ` Greg KH
2014-04-03 20:21 ` H. Peter Anvin [this message]
2014-04-03 23:41 ` [PATCH] " Alexandre Demers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=533DC2CC.5090408@zytor.com \
--to=hpa@zytor.com \
--cc=P@draigbrady.com \
--cc=alexandre.f.demers@gmail.com \
--cc=d@falconindy.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=stable@vger.kernel.org \
--cc=thomas@archlinux.org \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).