From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Message-ID: <533DC2CC.5090408@zytor.com> Date: Thu, 03 Apr 2014 13:21:32 -0700 From: "H. Peter Anvin" MIME-Version: 1.0 To: =?UTF-8?B?VGhvbWFzIELDpGNobGVy?= , tj@kernel.org CC: d@falconindy.com, linux-kernel@vger.kernel.org, gregkh@linuxfoundation.org, P@draigbrady.com, alexandre.f.demers@gmail.com, "3.14" Subject: Re: [PATCH] fs: Don't return 0 from get_anon_bdev References: <20140403191617.GB2472@mtj.dyndns.org> <1396554595-11796-1-git-send-email-thomas@archlinux.org> In-Reply-To: <1396554595-11796-1-git-send-email-thomas@archlinux.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: On 04/03/2014 12:49 PM, Thomas Bächler wrote: > Commit 9e30cc9595303b27b48 removed an internal mount. This > has the side-effect that rootfs now has FSID 0. Many > userspace utilities assume that st_dev in struct stat > is never 0, so this change breaks a number of tools in > early userspace. > > Since we don't know how many userspace programs are affected, > make sure that FSID is at least 1. > > References: http://article.gmane.org/gmane.linux.kernel/1666905 > References: http://permalink.gmane.org/gmane.linux.utilities.util-linux-ng/8557 > Cc: 3.14 > Signed-off-by: Thomas Bächler > --- > fs/super.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > Acked-by: H. Peter Anvin It is worth noting that zero has been documented as a null device number since at least 1995, probably more like 1993. -hpa