* Re: [PATCH] drivers:cpufreq:unicore32: fix typo issue for 'clk' [not found] <53429445.5000005@gmail.com> @ 2014-04-07 12:08 ` Viresh Kumar 2014-04-08 1:01 ` Chen Gang 0 siblings, 1 reply; 7+ messages in thread From: Viresh Kumar @ 2014-04-07 12:08 UTC (permalink / raw) To: Chen Gang Cc: Guan Xuetao, Rafael J. Wysocki, cpufreq@vger.kernel.org, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, stable On 7 April 2014 17:34, Chen Gang <gang.chen.5i5j@gmail.com> wrote: > Need use 'clk' instead of 'mclk', which is the original removed local > variable. > > The related original commit: > > "652ed95 cpufreq: introduce cpufreq_generic_get() routine" > > The related error with allmodconfig for unicore32: > > CC drivers/cpufreq/unicore2-cpufreq.o > drivers/cpufreq/unicore2-cpufreq.c: In function 'ucv2_target': > drivers/cpufreq/unicore2-cpufreq.c:48: error: 'struct cpufreq_policy' has no member named 'mclk' > make[2]: *** [drivers/cpufreq/unicore2-cpufreq.o] Error 1 > make[1]: *** [drivers/cpufreq] Error 2 > make: *** [drivers] Error 2 > > > Signed-off-by: Chen Gang <gang.chen.5i5j@gmail.com> > --- > drivers/cpufreq/unicore2-cpufreq.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Stupid mistake. Acked-by: Viresh Kumar <viresh.kumar@linaro.org> @stable: please apply this for v3.14, as it broke in that cycle.. ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] drivers:cpufreq:unicore32: fix typo issue for 'clk' 2014-04-07 12:08 ` [PATCH] drivers:cpufreq:unicore32: fix typo issue for 'clk' Viresh Kumar @ 2014-04-08 1:01 ` Chen Gang 2014-04-08 4:08 ` Viresh Kumar 0 siblings, 1 reply; 7+ messages in thread From: Chen Gang @ 2014-04-08 1:01 UTC (permalink / raw) To: Viresh Kumar Cc: Guan Xuetao, Rafael J. Wysocki, cpufreq@vger.kernel.org, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, stable On 04/07/2014 08:08 PM, Viresh Kumar wrote: > On 7 April 2014 17:34, Chen Gang <gang.chen.5i5j@gmail.com> wrote: >> Need use 'clk' instead of 'mclk', which is the original removed local >> variable. >> >> The related original commit: >> >> "652ed95 cpufreq: introduce cpufreq_generic_get() routine" >> >> The related error with allmodconfig for unicore32: >> >> CC drivers/cpufreq/unicore2-cpufreq.o >> drivers/cpufreq/unicore2-cpufreq.c: In function 'ucv2_target': >> drivers/cpufreq/unicore2-cpufreq.c:48: error: 'struct cpufreq_policy' has no member named 'mclk' >> make[2]: *** [drivers/cpufreq/unicore2-cpufreq.o] Error 1 >> make[1]: *** [drivers/cpufreq] Error 2 >> make: *** [drivers] Error 2 >> >> >> Signed-off-by: Chen Gang <gang.chen.5i5j@gmail.com> >> --- >> drivers/cpufreq/unicore2-cpufreq.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) > > Stupid mistake. > It is very easy to lead other members to make mistakes, or let ourself make mistakes. > Acked-by: Viresh Kumar <viresh.kumar@linaro.org> > > @stable: please apply this for v3.14, as it broke in that cycle.. > Thank you. Thanks. -- Chen Gang Open, share, and attitude like air, water, and life which God blessed ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] drivers:cpufreq:unicore32: fix typo issue for 'clk' 2014-04-08 1:01 ` Chen Gang @ 2014-04-08 4:08 ` Viresh Kumar 2014-04-08 4:39 ` Chen Gang 2014-04-08 11:11 ` Rafael J. Wysocki 0 siblings, 2 replies; 7+ messages in thread From: Viresh Kumar @ 2014-04-08 4:08 UTC (permalink / raw) To: Chen Gang Cc: Guan Xuetao, Rafael J. Wysocki, cpufreq@vger.kernel.org, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, stable On 8 April 2014 06:31, Chen Gang <gang.chen.5i5j@gmail.com> wrote: >> @stable: please apply this for v3.14, as it broke in that cycle.. This wouldn't work.. > Thank you. Can you please send it again for stable as well? Add my Ack in the patch and follow what's mentioned here: Documentation/stable_kernel_rules.txt ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] drivers:cpufreq:unicore32: fix typo issue for 'clk' 2014-04-08 4:08 ` Viresh Kumar @ 2014-04-08 4:39 ` Chen Gang 2014-04-08 5:29 ` Viresh Kumar 2014-04-08 11:11 ` Rafael J. Wysocki 1 sibling, 1 reply; 7+ messages in thread From: Chen Gang @ 2014-04-08 4:39 UTC (permalink / raw) To: Viresh Kumar Cc: Guan Xuetao, Rafael J. Wysocki, cpufreq@vger.kernel.org, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, stable On 04/08/2014 12:08 PM, Viresh Kumar wrote: > On 8 April 2014 06:31, Chen Gang <gang.chen.5i5j@gmail.com> wrote: >>> @stable: please apply this for v3.14, as it broke in that cycle.. > > This wouldn't work.. > >> Thank you. > > Can you please send it again for stable as well? Add my Ack in the patch > and follow what's mentioned here: > > Documentation/stable_kernel_rules.txt > OK, I will/should try within this week, thanks. Thanks. -- Chen Gang Open, share, and attitude like air, water, and life which God blessed ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] drivers:cpufreq:unicore32: fix typo issue for 'clk' 2014-04-08 4:39 ` Chen Gang @ 2014-04-08 5:29 ` Viresh Kumar 2014-04-08 6:51 ` Chen Gang 0 siblings, 1 reply; 7+ messages in thread From: Viresh Kumar @ 2014-04-08 5:29 UTC (permalink / raw) To: Chen Gang Cc: Guan Xuetao, Rafael J. Wysocki, cpufreq@vger.kernel.org, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, stable, Greg Kroah-Hartman On 8 April 2014 10:09, Chen Gang <gang.chen.5i5j@gmail.com> wrote: > OK, I will/should try within this week, thanks. Rafael has already applied this patch and has mentioned stable in 'Cc:' field. And it looks it will be applied automatically and you don't need to do anything now :) commit b4ddad95020e65cfbbf9aee63d3bcdf682794ade Author: Chen Gang <gang.chen.5i5j@gmail.com> Date: Mon Apr 7 20:04:21 2014 +0800 cpufreq: unicore32: fix typo issue for 'clk' Need use 'clk' instead of 'mclk', which is the original removed local variable. The related original commit: "652ed95 cpufreq: introduce cpufreq_generic_get() routine" The related error with allmodconfig for unicore32: CC drivers/cpufreq/unicore2-cpufreq.o drivers/cpufreq/unicore2-cpufreq.c: In function 'ucv2_target': drivers/cpufreq/unicore2-cpufreq.c:48: error: 'struct cpufreq_policy' has no member named 'mclk' make[2]: *** [drivers/cpufreq/unicore2-cpufreq.o] Error 1 make[1]: *** [drivers/cpufreq] Error 2 make: *** [drivers] Error 2 Fixes: 652ed95d5fa6 (cpufreq: introduce cpufreq_generic_get() routine) Signed-off-by: Chen Gang <gang.chen.5i5j@gmail.com> Acked-by: Viresh Kumar <viresh.kumar@linaro.org> Cc: 3.14+ <stable@vger.kernel.org> # 3.14+ Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com> ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] drivers:cpufreq:unicore32: fix typo issue for 'clk' 2014-04-08 5:29 ` Viresh Kumar @ 2014-04-08 6:51 ` Chen Gang 0 siblings, 0 replies; 7+ messages in thread From: Chen Gang @ 2014-04-08 6:51 UTC (permalink / raw) To: Viresh Kumar Cc: Guan Xuetao, Rafael J. Wysocki, cpufreq@vger.kernel.org, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, stable, Greg Kroah-Hartman On 04/08/2014 01:29 PM, Viresh Kumar wrote: > On 8 April 2014 10:09, Chen Gang <gang.chen.5i5j@gmail.com> wrote: >> OK, I will/should try within this week, thanks. > > Rafael has already applied this patch and has mentioned stable in > 'Cc:' field. And it looks it will be applied automatically and you don't > need to do anything now :) > OK, thank all of you!! :-) > > commit b4ddad95020e65cfbbf9aee63d3bcdf682794ade > Author: Chen Gang <gang.chen.5i5j@gmail.com> > Date: Mon Apr 7 20:04:21 2014 +0800 > > cpufreq: unicore32: fix typo issue for 'clk' > > Need use 'clk' instead of 'mclk', which is the original removed local > variable. > > The related original commit: > > "652ed95 cpufreq: introduce cpufreq_generic_get() routine" > > The related error with allmodconfig for unicore32: > > CC drivers/cpufreq/unicore2-cpufreq.o > drivers/cpufreq/unicore2-cpufreq.c: In function 'ucv2_target': > drivers/cpufreq/unicore2-cpufreq.c:48: error: 'struct > cpufreq_policy' has no member named 'mclk' > make[2]: *** [drivers/cpufreq/unicore2-cpufreq.o] Error 1 > make[1]: *** [drivers/cpufreq] Error 2 > make: *** [drivers] Error 2 > > Fixes: 652ed95d5fa6 (cpufreq: introduce cpufreq_generic_get() routine) > Signed-off-by: Chen Gang <gang.chen.5i5j@gmail.com> > Acked-by: Viresh Kumar <viresh.kumar@linaro.org> > Cc: 3.14+ <stable@vger.kernel.org> # 3.14+ > Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com> > -- Chen Gang Open, share, and attitude like air, water, and life which God blessed ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] drivers:cpufreq:unicore32: fix typo issue for 'clk' 2014-04-08 4:08 ` Viresh Kumar 2014-04-08 4:39 ` Chen Gang @ 2014-04-08 11:11 ` Rafael J. Wysocki 1 sibling, 0 replies; 7+ messages in thread From: Rafael J. Wysocki @ 2014-04-08 11:11 UTC (permalink / raw) To: Viresh Kumar Cc: Chen Gang, Guan Xuetao, cpufreq@vger.kernel.org, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, stable On Tuesday, April 08, 2014 09:38:16 AM Viresh Kumar wrote: > On 8 April 2014 06:31, Chen Gang <gang.chen.5i5j@gmail.com> wrote: > >> @stable: please apply this for v3.14, as it broke in that cycle.. > > This wouldn't work.. > > > Thank you. > > Can you please send it again for stable as well? I have labeled it for -stable and it doesn't work like that. -stable won't take any patches you send them before the commits in question are in the Linus' tree anyway. And you need to provide the original commit hashes then. Thanks! -- I speak only for myself. Rafael J. Wysocki, Intel Open Source Technology Center. ^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2014-04-08 11:11 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <53429445.5000005@gmail.com>
2014-04-07 12:08 ` [PATCH] drivers:cpufreq:unicore32: fix typo issue for 'clk' Viresh Kumar
2014-04-08 1:01 ` Chen Gang
2014-04-08 4:08 ` Viresh Kumar
2014-04-08 4:39 ` Chen Gang
2014-04-08 5:29 ` Viresh Kumar
2014-04-08 6:51 ` Chen Gang
2014-04-08 11:11 ` Rafael J. Wysocki
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).