[PATCH] extcon: max14577: Fix probe failure on successful work queue

[PATCH] extcon: max14577: Fix probe failure on successful work queue

[Krzysztof Kozlowski]

In probe the driver queued delayed work for cable detection and
returned the result of queue_delayed_work() call. However the return
value of queue_delayed_work() does not indicate an error and in normal
condition it returns true which means successful work queue.
This effectively resulted in probe failure:
[    2.088204] max14577-muic: probe of max77836-muic failed with error 1

Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
Cc: <stable@vger.kernel.org>
Fixes: 962e56bfcf0b ("extcon: max14577: Add extcon-max14577 driver...")
---
 drivers/extcon/extcon-max14577.c | 7 +------
 1 file changed, 1 insertion(+), 6 deletions(-)

diff --git a/drivers/extcon/extcon-max14577.c b/drivers/extcon/extcon-max14577.c
index 3846941801b8..1fef08dc7c0f 100644
--- a/drivers/extcon/extcon-max14577.c
+++ b/drivers/extcon/extcon-max14577.c
@@ -710,13 +710,8 @@ static int max14577_muic_probe(struct platform_device *pdev)
 	 * driver should notify cable state to upper layer.
 	 */
 	INIT_DELAYED_WORK(&info->wq_detcable, max14577_muic_detect_cable_wq);
-	ret = queue_delayed_work(system_power_efficient_wq, &info->wq_detcable,
+	queue_delayed_work(system_power_efficient_wq, &info->wq_detcable,
 			delay_jiffies);
-	if (ret < 0) {
-		dev_err(&pdev->dev,
-			"failed to schedule delayed work for cable detect\n");
-		goto err_extcon;
-	}
 
 	return ret;
 
-- 
1.8.3.2

Re: [PATCH] extcon: max14577: Fix probe failure on successful work queue

[Chanwoo Choi]

Hi Krzysztof,

On 04/09/2014 06:56 PM, Krzysztof Kozlowski wrote:
> In probe the driver queued delayed work for cable detection and
> returned the result of queue_delayed_work() call. However the return
> value of queue_delayed_work() does not indicate an error and in normal
> condition it returns true which means successful work queue.
> This effectively resulted in probe failure:
> [    2.088204] max14577-muic: probe of max77836-muic failed with error 1
> 
> Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
> Cc: <stable@vger.kernel.org>
> Fixes: 962e56bfcf0b ("extcon: max14577: Add extcon-max14577 driver...")
> ---
>  drivers/extcon/extcon-max14577.c | 7 +------
>  1 file changed, 1 insertion(+), 6 deletions(-)

Applied this patch.
but, you could check this patch on extcon-next branch
after few days. becuase I have firewall issue of kerner.org.

Thanks,
Chanwoo Choi