From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Message-ID: <53483896.9070404@linux.intel.com> Date: Fri, 11 Apr 2014 11:46:46 -0700 From: "H. Peter Anvin" MIME-Version: 1.0 To: Linus Torvalds , Brian Gerst CC: Ingo Molnar , "H. Peter Anvin" , Linux Kernel Mailing List , Thomas Gleixner , stable Subject: Re: [tip:x86/urgent] x86-64, modify_ldt: Ban 16-bit segments on 64-bit kernels References: In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: On 04/11/2014 11:41 AM, Linus Torvalds wrote: > > Ok, so you actually do this on x86-64, and it currently works? For > some reason I thought that 16-bit windows apps already didn't work. > Some will work, because not all 16-bit software care about the upper half of ESP getting randomly corrupted. That is the "functionality bit" of the problem. The other bit, of course, is that that random corruption is the address of the kernel stack. > Because if we have working users of this, then I don't think we can do > the "we don't support 16-bit segments", or at least we need to make it > runtime configurable. I'll let you pick what the policy should be here. I personally think that we have to be able to draw a line somewhere sometimes (Microsoft themselves haven't supported running 16-bit binaries for several Windows generations now), but it is your policy, not mine. -hpa