stable.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Paolo Bonzini <pbonzini@redhat.com>
To: Marcelo Tosatti <mtosatti@redhat.com>
Cc: linux-kernel@vger.kernel.org, yang.z.zhang@intel.com,
	stable@vger.kernel.org
Subject: Re: [PATCH] KVM: lapic: sync highest ISR to hardware apic on EOI
Date: Wed, 28 May 2014 19:11:37 +0200	[thread overview]
Message-ID: <538618C9.10600@redhat.com> (raw)
In-Reply-To: <20140528165623.GA10861@amt.cnet>

Il 28/05/2014 18:57, Marcelo Tosatti ha scritto:
> On Fri, May 23, 2014 at 04:51:53PM +0200, Paolo Bonzini wrote:
>> When Hyper-V enlightenments are in effect, Windows prefers to issue an
>> Hyper-V MSR write to issue an EOI rather than an x2apic MSR write.
>> The Hyper-V MSR write is not handled by the processor, and besides
>> being slower, this also causes bugs with APIC virtualization.  The
>> reason is that on EOI the processor will modify the highest in-service
>> interrupt (SVI) field of the VMCS, as explained in section 29.1.4 of
>> the SDM.
>>
>> We need to do the same, and be careful not to muck with the isr_count
>> and highest_isr_cache fields that are unused when virtual interrupt
>> delivery is enabled.
>>
>> Cc: stable@vger.kernel.org
>> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
>> ---
>>  arch/x86/kvm/lapic.c |   62 ++++++++++++++++++++++++++++++++++---------------
>>  1 files changed, 43 insertions(+), 19 deletions(-)
>
> Why not disable Hyper-V APIC enlightenment if APIC-V is available ?

That would be a good suggestion indeed, but it doesn't help if you just 
keep your old configuration and get new hardware.

Paolo


      reply	other threads:[~2014-05-28 17:11 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-05-23 14:51 [PATCH] KVM: lapic: sync highest ISR to hardware apic on EOI Paolo Bonzini
2014-05-26  3:44 ` Zhang, Yang Z
2014-05-26 13:07   ` Paolo Bonzini
2014-05-27  0:26     ` Zhang, Yang Z
2014-05-26 14:28 ` Michael S. Tsirkin
2014-05-26 14:56   ` Paolo Bonzini
2014-05-26 15:39     ` Michael S. Tsirkin
2014-05-28 16:57 ` Marcelo Tosatti
2014-05-28 17:11   ` Paolo Bonzini [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=538618C9.10600@redhat.com \
    --to=pbonzini@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mtosatti@redhat.com \
    --cc=stable@vger.kernel.org \
    --cc=yang.z.zhang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).