public inbox for stable@vger.kernel.org
 help / color / mirror / Atom feed
From: "Stefan (metze) Metzmacher" <metze@samba.org>
To: "Björn Baumbach" <bb@sernet.de>, "Steve French" <sfrench@samba.org>
Cc: linux-cifs@vger.kernel.org, linux-kernel@vger.kernel.org,
	stable@vger.kernel.org, Steve French <smfrench@gmail.com>,
	Pavel Shilovsky <piastryyy@gmail.com>
Subject: Re: [PATCH] fs/cifs: fix regression in cifs_create_mf_symlink()
Date: Mon, 16 Jun 2014 15:49:49 +0200	[thread overview]
Message-ID: <539EF5FD.5000307@samba.org> (raw)
In-Reply-To: <1402394606-7910-1-git-send-email-bb@sernet.de>

[-- Attachment #1: Type: text/plain, Size: 1141 bytes --]

Hi Steve,

any comments on this? How can we get this fixed upstream?

Thanks!
metze

Am 10.06.2014 12:03, schrieb Björn Baumbach:
> commit d81b8a40e2ece0a9ab57b1fe1798e291e75bf8fc
> ("CIFS: Cleanup cifs open codepath")
> changed disposition to FILE_OPEN.
> 
> Signed-off-by: Björn Baumbach <bb@sernet.de>
> Signed-off-by: Stefan Metzmacher <metze@samba.org>
> Reviewed-by: Stefan Metzmacher <metze@samba.org>
> Cc: <stable@vger.kernel.org> # v3.14+
> Cc: Pavel Shilovsky <piastry@etersoft.ru>
> Cc: Steve French <sfrench@samba.org>
> ---
>  fs/cifs/link.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/fs/cifs/link.c b/fs/cifs/link.c
> index 264ece7..68559fd 100644
> --- a/fs/cifs/link.c
> +++ b/fs/cifs/link.c
> @@ -374,7 +374,7 @@ cifs_create_mf_symlink(unsigned int xid, struct cifs_tcon *tcon,
>  	oparms.cifs_sb = cifs_sb;
>  	oparms.desired_access = GENERIC_WRITE;
>  	oparms.create_options = create_options;
> -	oparms.disposition = FILE_OPEN;
> +	oparms.disposition = FILE_CREATE;
>  	oparms.path = path;
>  	oparms.fid = &fid;
>  	oparms.reconnect = false;
> 


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 263 bytes --]

  reply	other threads:[~2014-06-16 13:49 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-06-10 10:03 [PATCH] fs/cifs: fix regression in cifs_create_mf_symlink() Björn Baumbach
2014-06-16 13:49 ` Stefan (metze) Metzmacher [this message]
2014-06-16 22:07   ` Steve French
2014-06-17  8:56     ` Stefan (metze) Metzmacher

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=539EF5FD.5000307@samba.org \
    --to=metze@samba.org \
    --cc=bb@sernet.de \
    --cc=linux-cifs@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=piastryyy@gmail.com \
    --cc=sfrench@samba.org \
    --cc=smfrench@gmail.com \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox