From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Message-ID: <53C375E8.8090901@suse.de> Date: Mon, 14 Jul 2014 08:17:12 +0200 From: Hannes Reinecke MIME-Version: 1.0 To: "K. Y. Srinivasan" , jasowang@redhat.com, apw@canonical.com, linux-kernel@vger.kernel.org, devel@linuxdriverproject.org, ohering@suse.com, jbottomley@parallels.com, hch@infradead.org, linux-scsi@vger.kernel.org CC: stable@vger.kernel.org Subject: Re: [PATCH 6/7] drivers: scsi: storvsc: Set srb_flags in all cases References: <1405183684-23928-1-git-send-email-kys@microsoft.com> <1405183712-23967-1-git-send-email-kys@microsoft.com> <1405183712-23967-6-git-send-email-kys@microsoft.com> In-Reply-To: <1405183712-23967-6-git-send-email-kys@microsoft.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: On 07/12/2014 06:48 PM, K. Y. Srinivasan wrote: > Correctly set SRB flags for all valid I/O directions. Some IHV drivers on the > Windows host require this. The host validates the command and SRB flags > prior to passing the command down to native driver stack. > > Signed-off-by: K. Y. Srinivasan > Cc: > --- > drivers/scsi/storvsc_drv.c | 12 +++++------- > 1 files changed, 5 insertions(+), 7 deletions(-) > > diff --git a/drivers/scsi/storvsc_drv.c b/drivers/scsi/storvsc_drv.c > index 3516761..9342ba4 100644 > --- a/drivers/scsi/storvsc_drv.c > +++ b/drivers/scsi/storvsc_drv.c > @@ -1599,26 +1599,24 @@ static int storvsc_queuecommand(struct Scsi_Host *host, struct scsi_cmnd *scmnd) > vm_srb = &cmd_request->vstor_packet.vm_srb; > vm_srb->win8_extension.time_out_value = 60; > > + vm_srb->win8_extension.srb_flags |= > + (SRB_FLAGS_QUEUE_ACTION_ENABLE | > + SRB_FLAGS_DISABLE_SYNCH_TRANSFER); > > /* Build the SRB */ > switch (scmnd->sc_data_direction) { > case DMA_TO_DEVICE: > vm_srb->data_in = WRITE_TYPE; > vm_srb->win8_extension.srb_flags |= SRB_FLAGS_DATA_OUT; > - vm_srb->win8_extension.srb_flags |= > - (SRB_FLAGS_QUEUE_ACTION_ENABLE | > - SRB_FLAGS_DISABLE_SYNCH_TRANSFER); > break; > case DMA_FROM_DEVICE: > vm_srb->data_in = READ_TYPE; > vm_srb->win8_extension.srb_flags |= SRB_FLAGS_DATA_IN; > - vm_srb->win8_extension.srb_flags |= > - (SRB_FLAGS_QUEUE_ACTION_ENABLE | > - SRB_FLAGS_DISABLE_SYNCH_TRANSFER); > break; > default: > vm_srb->data_in = UNKNOWN_TYPE; > - vm_srb->win8_extension.srb_flags = 0; > + vm_srb->win8_extension.srb_flags |= (SRB_FLAGS_DATA_IN | > + SRB_FLAGS_DATA_OUT); > break; > } > > Reviewed-by: Hannes Reinecke Cheers, Hannes -- Dr. Hannes Reinecke zSeries & Storage hare@suse.de +49 911 74053 688 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N�rnberg GF: J. Hawn, J. Guild, F. Imend�rffer, HRB 16746 (AG N�rnberg)