From: Roger Quadros <rogerq@ti.com>
To: Alan Stern <stern@rowland.harvard.edu>, <gregkh@linuxfoundation.org>
Cc: <balbi@ti.com>, <ming.lei@canonical.com>, <mwelling@emacinc.com>,
<stefan@herbrechtsmeier.net>, <linux-usb@vger.kernel.org>,
<linux-kernel@vger.kernel.org>, "[3.8+]" <stable@vger.kernel.org>
Subject: Re: [PATCH] usb: hub: Prevent hub autosuspend if usbcore.autosuspend is -1
Date: Wed, 27 Aug 2014 13:31:24 +0300 [thread overview]
Message-ID: <53FDB37C.8030707@ti.com> (raw)
In-Reply-To: <Pine.LNX.4.44L0.1408041006530.1169-100000@iolanthe.rowland.org>
On 08/04/2014 05:07 PM, Alan Stern wrote:
> On Mon, 4 Aug 2014, Roger Quadros wrote:
>
>> If user specifies that USB autosuspend must be disabled by module
>> parameter "usbcore.autosuspend=-1" then we must prevent
>> autosuspend of USB hub devices as well.
>>
>> commit 596d789a211d introduced in v3.8 changed the original behaivour
>> and stopped respecting the usbcore.autosuspend parameter for hubs.
>>
>> Fixes: 596d789a211d "USB: set hub's default autosuspend delay as 0"
>>
>> Cc: [3.8+] <stable@vger.kernel.org>
>> Signed-off-by: Roger Quadros <rogerq@ti.com>
>
> Acked-by: Alan Stern <stern@rowland.harvard.edu>
>
Just noticed the below error by the Intel's build script
> tree: git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git usb-linus
> head: 039368901ad0a6476c7ecf0cfe4f84d735e30135
> commit: bdd405d2a5287bdb9b04670ea255e1f122138e66 [19/20] usb: hub: Prevent hub autosuspend if usbcore.autosuspend is -1
> config: make ARCH=sparc64 defconfig
>
> All error/warnings:
>
> drivers/usb/core/hub.c: In function 'hub_probe':
>>> drivers/usb/core/hub.c:1735:21: error: 'struct dev_pm_info' has no member named 'autosuspend_delay'
> if (hdev->dev.power.autosuspend_delay >= 0)
> ^
Seems like the "if" has to be placed within a #ifdef CONFIG_PM_RUNTIME.
Greg,
Should I send a v2 of this patch or a fix on top of your usb-linus branch?
cheers,
-roger
next prev parent reply other threads:[~2014-08-27 10:31 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-04 9:44 [PATCH] usb: hub: Prevent hub autosuspend if usbcore.autosuspend is -1 Roger Quadros
2014-08-04 14:07 ` Alan Stern
2014-08-27 10:31 ` Roger Quadros [this message]
2014-08-27 19:20 ` Greg KH
2014-08-04 15:45 ` Michael Welling
2014-08-27 12:11 ` [PATCH v2] " Roger Quadros
2014-08-27 19:23 ` Greg KH
2014-08-27 21:02 ` Greg KH
2014-08-28 9:52 ` Roger Quadros
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53FDB37C.8030707@ti.com \
--to=rogerq@ti.com \
--cc=balbi@ti.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=ming.lei@canonical.com \
--cc=mwelling@emacinc.com \
--cc=stable@vger.kernel.org \
--cc=stefan@herbrechtsmeier.net \
--cc=stern@rowland.harvard.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).