stable.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Roger Quadros <rogerq@ti.com>
To: <gregkh@linuxfoundation.org>, <stern@rowland.harvard.edu>
Cc: <balbi@ti.com>, <ming.lei@canonical.com>, <mwelling@emacinc.com>,
	<stefan@herbrechtsmeier.net>, <linux-usb@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>, "[3.8+]" <stable@vger.kernel.org>
Subject: [PATCH v2] usb: hub: Prevent hub autosuspend if usbcore.autosuspend is -1
Date: Wed, 27 Aug 2014 15:11:10 +0300	[thread overview]
Message-ID: <53FDCADE.3040601@ti.com> (raw)
In-Reply-To: <1407145486-14013-1-git-send-email-rogerq@ti.com>

If user specifies that USB autosuspend must be disabled by module
parameter "usbcore.autosuspend=-1" then we must prevent
autosuspend of USB hub devices as well.

commit 596d789a211d introduced in v3.8 changed the original behaivour
and stopped respecting the usbcore.autosuspend parameter for hubs.

Fixes: 596d789a211d "USB: set hub's default autosuspend delay as 0"

Cc: [3.8+] <stable@vger.kernel.org>
Signed-off-by: Roger Quadros <rogerq@ti.com>
---
 drivers/usb/core/hub.c | 8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)

diff --git a/drivers/usb/core/hub.c b/drivers/usb/core/hub.c
index 8a4dcbc..59b599d 100644
--- a/drivers/usb/core/hub.c
+++ b/drivers/usb/core/hub.c
@@ -1728,8 +1728,14 @@ static int hub_probe(struct usb_interface *intf, const struct usb_device_id *id)
 	 * - Change autosuspend delay of hub can avoid unnecessary auto
 	 *   suspend timer for hub, also may decrease power consumption
 	 *   of USB bus.
+	 *
+	 * - If user has indicated to prevent autosuspend by passing
+	 *   usbcore.autosuspend = -1 then keep autosuspend disabled.
 	 */
-	pm_runtime_set_autosuspend_delay(&hdev->dev, 0);
+#ifdef CONFIG_PM_RUNTIME
+	if (hdev->dev.power.autosuspend_delay >= 0)
+		pm_runtime_set_autosuspend_delay(&hdev->dev, 0);
+#endif
 
 	/*
 	 * Hubs have proper suspend/resume support, except for root hubs
-- 
1.8.3.2


  parent reply	other threads:[~2014-08-27 12:11 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-08-04  9:44 [PATCH] usb: hub: Prevent hub autosuspend if usbcore.autosuspend is -1 Roger Quadros
2014-08-04 14:07 ` Alan Stern
2014-08-27 10:31   ` Roger Quadros
2014-08-27 19:20     ` Greg KH
2014-08-04 15:45 ` Michael Welling
2014-08-27 12:11 ` Roger Quadros [this message]
2014-08-27 19:23   ` [PATCH v2] " Greg KH
2014-08-27 21:02     ` Greg KH
2014-08-28  9:52       ` Roger Quadros

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=53FDCADE.3040601@ti.com \
    --to=rogerq@ti.com \
    --cc=balbi@ti.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=ming.lei@canonical.com \
    --cc=mwelling@emacinc.com \
    --cc=stable@vger.kernel.org \
    --cc=stefan@herbrechtsmeier.net \
    --cc=stern@rowland.harvard.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).