From: Xin Li <xin@zytor.com>
To: "Rafael J. Wysocki" <rafael@kernel.org>
Cc: linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org,
stable@vger.kernel.org, pavel@kernel.org, tglx@linutronix.de,
mingo@redhat.com, bp@alien8.de, dave.hansen@linux.intel.com,
x86@kernel.org, hpa@zytor.com, xi.pardee@intel.com,
todd.e.brandt@intel.com
Subject: Re: [PATCH v1 1/1] x86/fred: Fix system hang during S4 resume with FRED enabled
Date: Mon, 31 Mar 2025 23:34:06 -0700 [thread overview]
Message-ID: <53a6f46c-1b96-45a0-9593-fa8eb8941bbf@zytor.com> (raw)
In-Reply-To: <CAJZ5v0jfak9K_7b=adf5ew-xDiGHUEPSp5ZpAGt66Okj-ovsGQ@mail.gmail.com>
On 3/31/2025 8:30 AM, Rafael J. Wysocki wrote:
>> + *
>> + * Note, FRED RSPs setup needs to access percpu data structures.
> And I'm not sure what you wanted to say here? Does this refer to the
> ordering of the code below or to something else?
Yes, this refers to the ordering of the code: FRED config restoration
needs to happen after wrmsrl(MSR_GS_BASE, ctxt->kernelmode_gs_base), or
the system still hangs.
I will make it explicit in the next iteration.
prev parent reply other threads:[~2025-04-01 6:34 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-26 6:25 [PATCH v1 1/1] x86/fred: Fix system hang during S4 resume with FRED enabled Xin Li (Intel)
2025-03-26 6:30 ` kernel test robot
2025-03-31 15:30 ` Rafael J. Wysocki
2025-03-31 16:19 ` Ingo Molnar
2025-03-31 20:03 ` H. Peter Anvin
2025-03-31 20:25 ` Rafael J. Wysocki
2025-04-01 8:22 ` Ingo Molnar
2025-04-01 6:34 ` Xin Li [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53a6f46c-1b96-45a0-9593-fa8eb8941bbf@zytor.com \
--to=xin@zytor.com \
--cc=bp@alien8.de \
--cc=dave.hansen@linux.intel.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=pavel@kernel.org \
--cc=rafael@kernel.org \
--cc=stable@vger.kernel.org \
--cc=tglx@linutronix.de \
--cc=todd.e.brandt@intel.com \
--cc=x86@kernel.org \
--cc=xi.pardee@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox