From: Ge Yang <yangge1116@126.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: akpm@linux-foundation.org, linux-mm@kvack.org,
linux-kernel@vger.kernel.org, stable@vger.kernel.org,
21cnbao@gmail.com, peterx@redhat.com,
baolin.wang@linux.alibaba.com, liuzixing@hygon.cn
Subject: Re: [PATCH] mm/gup: Use try_grab_page() instead of try_grab_folio() in gup slow path
Date: Fri, 28 Jun 2024 14:35:38 +0800 [thread overview]
Message-ID: <53ca3c9c-343a-44fd-b9c9-6c123b3da71d@126.com> (raw)
In-Reply-To: <Zn5UBMfT6LEpdpNW@infradead.org>
在 2024/6/28 14:11, Christoph Hellwig 写道:
> I was complaining that switching from a folio to a page interface
> is a retro-step. But try_grab_page and try_grab_folio actually
> both take a strut page argument and do similar but different things.
>
> Yikes!
>
>> -int __must_check try_grab_page(struct page *page, unsigned int flags)
>> +int __must_check try_grab_page(struct page *page, int refs, unsigned int flags)
>
> This would now make it a try_grab_pages. Also please try to avoid
> the overly lone lines here and in the external declaration.
Ok, thanks.
prev parent reply other threads:[~2024-06-28 6:52 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-27 8:53 [PATCH] mm/gup: Use try_grab_page() instead of try_grab_folio() in gup slow path yangge1116
2024-06-27 18:55 ` Peter Xu
2024-06-27 19:03 ` Yang Shi
2024-06-28 6:11 ` Christoph Hellwig
2024-06-28 6:35 ` Ge Yang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53ca3c9c-343a-44fd-b9c9-6c123b3da71d@126.com \
--to=yangge1116@126.com \
--cc=21cnbao@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=baolin.wang@linux.alibaba.com \
--cc=hch@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=liuzixing@hygon.cn \
--cc=peterx@redhat.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox