From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Message-id: <54379CE5.5090908@samsung.com> Date: Fri, 10 Oct 2014 17:46:29 +0900 From: Chanwoo Choi MIME-version: 1.0 To: Krzysztof Kozlowski Cc: MyungJoo Ham , Samuel Ortiz , Lee Jones , linux-kernel@vger.kernel.org, Kyungmin Park , Marek Szyprowski , Bartlomiej Zolnierkiewicz , stable@vger.kernel.org Subject: Re: [PATCH fixes 1/2] mfd: max77693: Use proper regmap for handling MUIC interrupts References: <1412929322-21908-1-git-send-email-k.kozlowski@samsung.com> In-reply-to: <1412929322-21908-1-git-send-email-k.kozlowski@samsung.com> Content-type: text/plain; charset=ISO-8859-1 Content-transfer-encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: On 10/10/2014 05:22 PM, Krzysztof Kozlowski wrote: > Interrupts coming from Maxim77693 MUIC block (MicroUSB Interface > Controller) were not handled at all because wrong regmap was used for > MUIC's regmap_irq_chip. > > The MUIC component of Maxim 77693 uses different I2C address thus second > regmap is created and used by max77693 extcon driver. The registers for > MUIC interrupts are also in that block and should be handled by that > second regmap. > > However the regmap irq chip for MUIC was configured with default regmap > which could not read MUIC registers. > > Signed-off-by: Krzysztof Kozlowski > Cc: > Fixes: 342d669c1ee4 ("mfd: max77693: Handle IRQs using regmap") > --- > drivers/mfd/max77693.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/mfd/max77693.c b/drivers/mfd/max77693.c > index 2277a11b6629..4b54da1ff7ab 100644 > --- a/drivers/mfd/max77693.c > +++ b/drivers/mfd/max77693.c > @@ -243,7 +243,7 @@ static int max77693_i2c_probe(struct i2c_client *i2c, > goto err_irq_charger; > } > > - ret = regmap_add_irq_chip(max77693->regmap, max77693->irq, > + ret = regmap_add_irq_chip(max77693->regmap_muic, max77693->irq, > IRQF_ONESHOT | IRQF_SHARED | > IRQF_TRIGGER_FALLING, 0, > &max77693_muic_irq_chip, > Reviewed-by: Chanwoo Choi Thanks, Chanwoo Choi