From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Message-ID: <54556A32.8020003@fb.com> Date: Sat, 1 Nov 2014 17:18:10 -0600 From: Jens Axboe MIME-Version: 1.0 To: Ben Hutchings , , CC: , Keith Busch Subject: Re: [PATCH 3.2 023/102] block: Fix dev_t minor allocation lifetime References: In-Reply-To: Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: On 2014-11-01 16:28, Ben Hutchings wrote: > 3.2.64-rc1 review patch. If anyone has any objections, please let me know. > > ------------------ > > From: Keith Busch > > commit 2da78092dda13f1efd26edbbf99a567776913750 upstream. > > Releases the dev_t minor when all references are closed to prevent > another device from acquiring the same major/minor. > > Since the partition's release may be invoked from call_rcu's soft-irq > context, the ext_dev_idr's mutex had to be replaced with a spinlock so > as not so sleep. > > Signed-off-by: Keith Busch > Signed-off-by: Jens Axboe > [bwh: Backported to 3.2: > - Adjust filename > - idr insertion API is different, and blk_alloc_devt() is preallocating > a node in a different way] As I've noted for pretty much every stable branch so far, you have to backport commit 46f341ffcfb5 as well, if you backport this one. -- Jens Axboe