From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Message-ID: <5456D944.90905@fb.com> Date: Sun, 2 Nov 2014 18:24:20 -0700 From: Jens Axboe MIME-Version: 1.0 To: Ben Hutchings CC: , , , Keith Busch Subject: Re: [PATCH 3.2 023/102] block: Fix dev_t minor allocation lifetime References: <54556A32.8020003@fb.com> <1414885706.27313.6.camel@decadent.org.uk> In-Reply-To: <1414885706.27313.6.camel@decadent.org.uk> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: On 2014-11-01 17:48, Ben Hutchings wrote: > On Sat, 2014-11-01 at 17:18 -0600, Jens Axboe wrote: >> On 2014-11-01 16:28, Ben Hutchings wrote: >>> 3.2.64-rc1 review patch. If anyone has any objections, please let me know. >>> >>> ------------------ >>> >>> From: Keith Busch >>> >>> commit 2da78092dda13f1efd26edbbf99a567776913750 upstream. >>> >>> Releases the dev_t minor when all references are closed to prevent >>> another device from acquiring the same major/minor. >>> >>> Since the partition's release may be invoked from call_rcu's soft-irq >>> context, the ext_dev_idr's mutex had to be replaced with a spinlock so >>> as not so sleep. >>> >>> Signed-off-by: Keith Busch >>> Signed-off-by: Jens Axboe >>> [bwh: Backported to 3.2: >>> - Adjust filename >>> - idr insertion API is different, and blk_alloc_devt() is preallocating >>> a node in a different way] >> >> As I've noted for pretty much every stable branch so far, you have to >> backport commit 46f341ffcfb5 as well, if you backport this one. > > I'm not caught up on reading the stable list, so I missed that. Thanks > for pointing it out again; I'll add it. Thanks, it keeps biting me in the ass that I didn't get a Fixes: added to that patch... -- Jens Axboe