* [Regression][v3.17][3.18][3.19-rc3] drm/radeon: re-enable dpm by default on BTC
@ 2015-01-07 22:51 Joseph Salisbury
2015-01-08 2:51 ` Deucher, Alexander
0 siblings, 1 reply; 9+ messages in thread
From: Joseph Salisbury @ 2015-01-07 22:51 UTC (permalink / raw)
To: alexander.deucher
Cc: stable@vger.kernel.org, LKML, christian.koenig, David Airlie,
dri-devel
Hi Alexander,
A kernel bug report was opened against Ubuntu [0]. After a kernel
bisect, it was found that reverting the following commit resolved this bug:
commit c08abf11900e19b14dd3a0cc3d105bd74519cd18
Author: Alex Deucher <alexander.deucher@amd.com>
Date: Mon Jul 14 12:01:40 2014 -0400
drm/radeon: re-enable dpm by default on BTC
The regression was introduced as of v3.17-rc1 and still exists in
current mainline. It has also made it's way into the stable releases.
I was hoping to get your feedback, since you are the patch author. Do
you think gathering any additional data will help diagnose this issue,
or would it be best to submit a revert request?
Thanks,
Joe
[0] http://pad.lv/1386534
^ permalink raw reply [flat|nested] 9+ messages in thread
* RE: [Regression][v3.17][3.18][3.19-rc3] drm/radeon: re-enable dpm by default on BTC
2015-01-07 22:51 [Regression][v3.17][3.18][3.19-rc3] drm/radeon: re-enable dpm by default on BTC Joseph Salisbury
@ 2015-01-08 2:51 ` Deucher, Alexander
2015-01-08 16:12 ` Joseph Salisbury
2015-01-08 16:25 ` Joseph Salisbury
0 siblings, 2 replies; 9+ messages in thread
From: Deucher, Alexander @ 2015-01-08 2:51 UTC (permalink / raw)
To: Joseph Salisbury
Cc: stable@vger.kernel.org, LKML, Koenig, Christian, David Airlie,
dri-devel
> -----Original Message-----
> From: Joseph Salisbury [mailto:joseph.salisbury@canonical.com]
> Sent: Wednesday, January 07, 2015 5:51 PM
> To: Deucher, Alexander
> Cc: stable@vger.kernel.org; LKML; Koenig, Christian; David Airlie; dri-devel
> Subject: [Regression][v3.17][3.18][3.19-rc3] drm/radeon: re-enable dpm by
> default on BTC
>
> Hi Alexander,
>
> A kernel bug report was opened against Ubuntu [0]. After a kernel
> bisect, it was found that reverting the following commit resolved this bug:
>
> commit c08abf11900e19b14dd3a0cc3d105bd74519cd18
> Author: Alex Deucher <alexander.deucher@amd.com>
> Date: Mon Jul 14 12:01:40 2014 -0400
>
> drm/radeon: re-enable dpm by default on BTC
>
> The regression was introduced as of v3.17-rc1 and still exists in
> current mainline. It has also made it's way into the stable releases.
>
> I was hoping to get your feedback, since you are the patch author. Do
> you think gathering any additional data will help diagnose this issue,
> or would it be best to submit a revert request?
>
Does revering b2dccf24e77 help? I'd hate to revert this patch because it disables power management for a whole family of chips. If it doesn't help I'd prefer to just add a quirk to disable it for the specific problematic board.
Alex
>
> Thanks,
>
> Joe
>
> [0] http://pad.lv/1386534
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [Regression][v3.17][3.18][3.19-rc3] drm/radeon: re-enable dpm by default on BTC
2015-01-08 2:51 ` Deucher, Alexander
@ 2015-01-08 16:12 ` Joseph Salisbury
2015-01-08 16:25 ` Joseph Salisbury
1 sibling, 0 replies; 9+ messages in thread
From: Joseph Salisbury @ 2015-01-08 16:12 UTC (permalink / raw)
To: Deucher, Alexander
Cc: stable@vger.kernel.org, LKML, Koenig, Christian, David Airlie,
dri-devel
On 01/07/2015 09:51 PM, Deucher, Alexander wrote:
>
>> -----Original Message-----
>> From: Joseph Salisbury [mailto:joseph.salisbury@canonical.com]
>> Sent: Wednesday, January 07, 2015 5:51 PM
>> To: Deucher, Alexander
>> Cc: stable@vger.kernel.org; LKML; Koenig, Christian; David Airlie; dri-devel
>> Subject: [Regression][v3.17][3.18][3.19-rc3] drm/radeon: re-enable dpm by
>> default on BTC
>>
>> Hi Alexander,
>>
>> A kernel bug report was opened against Ubuntu [0]. After a kernel
>> bisect, it was found that reverting the following commit resolved this bug:
>>
>> commit c08abf11900e19b14dd3a0cc3d105bd74519cd18
>> Author: Alex Deucher <alexander.deucher@amd.com>
>> Date: Mon Jul 14 12:01:40 2014 -0400
>>
>> drm/radeon: re-enable dpm by default on BTC
>>
>> The regression was introduced as of v3.17-rc1 and still exists in
>> current mainline. It has also made it's way into the stable releases.
>>
>> I was hoping to get your feedback, since you are the patch author. Do
>> you think gathering any additional data will help diagnose this issue,
>> or would it be best to submit a revert request?
>>
> Does revering b2dccf24e77 help? I'd hate to revert this patch because it disables power management for a whole family of chips. If it doesn't help I'd prefer to just add a quirk to disable it for the specific problematic board.
We'll test and let you know. Thanks for the feedback, Alex!
>
> Alex
>
>> Thanks,
>>
>> Joe
>>
>> [0] http://pad.lv/1386534
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [Regression][v3.17][3.18][3.19-rc3] drm/radeon: re-enable dpm by default on BTC
2015-01-08 2:51 ` Deucher, Alexander
2015-01-08 16:12 ` Joseph Salisbury
@ 2015-01-08 16:25 ` Joseph Salisbury
2015-01-08 17:48 ` Deucher, Alexander
1 sibling, 1 reply; 9+ messages in thread
From: Joseph Salisbury @ 2015-01-08 16:25 UTC (permalink / raw)
To: Deucher, Alexander
Cc: stable@vger.kernel.org, LKML, Koenig, Christian, David Airlie,
dri-devel
On 01/07/2015 09:51 PM, Deucher, Alexander wrote:
>
>> -----Original Message-----
>> From: Joseph Salisbury [mailto:joseph.salisbury@canonical.com]
>> Sent: Wednesday, January 07, 2015 5:51 PM
>> To: Deucher, Alexander
>> Cc: stable@vger.kernel.org; LKML; Koenig, Christian; David Airlie; dri-devel
>> Subject: [Regression][v3.17][3.18][3.19-rc3] drm/radeon: re-enable dpm by
>> default on BTC
>>
>> Hi Alexander,
>>
>> A kernel bug report was opened against Ubuntu [0]. After a kernel
>> bisect, it was found that reverting the following commit resolved this bug:
>>
>> commit c08abf11900e19b14dd3a0cc3d105bd74519cd18
>> Author: Alex Deucher <alexander.deucher@amd.com>
>> Date: Mon Jul 14 12:01:40 2014 -0400
>>
>> drm/radeon: re-enable dpm by default on BTC
>>
>> The regression was introduced as of v3.17-rc1 and still exists in
>> current mainline. It has also made it's way into the stable releases.
>>
>> I was hoping to get your feedback, since you are the patch author. Do
>> you think gathering any additional data will help diagnose this issue,
>> or would it be best to submit a revert request?
>>
> Does revering b2dccf24e77 help? I'd hate to revert this patch because it disables power management for a whole family of chips. If it doesn't help I'd prefer to just add a quirk to disable it for the specific problematic board.
Commit b2dccf24e77 was added to mainline as of v3.18-rc1 and was not
cc'd to stable. We are also seeing this issue in the 3.13.y stable
kernel, which does not have commit b2dccf24e77 applied. However, we can
test reverting it in mainline?
>
> Alex
>
>> Thanks,
>>
>> Joe
>>
>> [0] http://pad.lv/1386534
^ permalink raw reply [flat|nested] 9+ messages in thread
* RE: [Regression][v3.17][3.18][3.19-rc3] drm/radeon: re-enable dpm by default on BTC
2015-01-08 16:25 ` Joseph Salisbury
@ 2015-01-08 17:48 ` Deucher, Alexander
2015-01-08 18:00 ` Joseph Salisbury
2015-01-08 21:58 ` Joseph Salisbury
0 siblings, 2 replies; 9+ messages in thread
From: Deucher, Alexander @ 2015-01-08 17:48 UTC (permalink / raw)
To: Joseph Salisbury
Cc: stable@vger.kernel.org, LKML, Koenig, Christian, David Airlie,
dri-devel
[-- Attachment #1: Type: text/plain, Size: 2285 bytes --]
> -----Original Message-----
> From: Joseph Salisbury [mailto:joseph.salisbury@canonical.com]
> Sent: Thursday, January 08, 2015 11:26 AM
> To: Deucher, Alexander
> Cc: stable@vger.kernel.org; LKML; Koenig, Christian; David Airlie; dri-devel
> Subject: Re: [Regression][v3.17][3.18][3.19-rc3] drm/radeon: re-enable dpm
> by default on BTC
>
> On 01/07/2015 09:51 PM, Deucher, Alexander wrote:
> >
> >> -----Original Message-----
> >> From: Joseph Salisbury [mailto:joseph.salisbury@canonical.com]
> >> Sent: Wednesday, January 07, 2015 5:51 PM
> >> To: Deucher, Alexander
> >> Cc: stable@vger.kernel.org; LKML; Koenig, Christian; David Airlie; dri-devel
> >> Subject: [Regression][v3.17][3.18][3.19-rc3] drm/radeon: re-enable dpm
> by
> >> default on BTC
> >>
> >> Hi Alexander,
> >>
> >> A kernel bug report was opened against Ubuntu [0]. After a kernel
> >> bisect, it was found that reverting the following commit resolved this bug:
> >>
> >> commit c08abf11900e19b14dd3a0cc3d105bd74519cd18
> >> Author: Alex Deucher <alexander.deucher@amd.com>
> >> Date: Mon Jul 14 12:01:40 2014 -0400
> >>
> >> drm/radeon: re-enable dpm by default on BTC
> >>
> >> The regression was introduced as of v3.17-rc1 and still exists in
> >> current mainline. It has also made it's way into the stable releases.
> >>
> >> I was hoping to get your feedback, since you are the patch author. Do
> >> you think gathering any additional data will help diagnose this issue,
> >> or would it be best to submit a revert request?
> >>
> > Does revering b2dccf24e77 help? I'd hate to revert this patch because it
> disables power management for a whole family of chips. If it doesn't help I'd
> prefer to just add a quirk to disable it for the specific problematic board.
> Commit b2dccf24e77 was added to mainline as of v3.18-rc1 and was not
> cc'd to stable. We are also seeing this issue in the 3.13.y stable
> kernel, which does not have commit b2dccf24e77 applied. However, we can
> test reverting it in mainline?
Nope. Won't make a difference. The attached patch adds a quirk list for dpm which will fix the issue for the affected boards.
Alex
>
> >
> > Alex
> >
> >> Thanks,
> >>
> >> Joe
> >>
> >> [0] http://pad.lv/1386534
[-- Attachment #2: 0001-drm-radeon-add-a-dpm-quirk-list.patch --]
[-- Type: application/octet-stream, Size: 2156 bytes --]
From 17199f4c6db21d58163e60538de8585a4e1b137c Mon Sep 17 00:00:00 2001
From: Alex Deucher <alexander.deucher@amd.com>
Date: Thu, 8 Jan 2015 10:46:33 -0500
Subject: [PATCH] drm/radeon: add a dpm quirk list
Disable dpm on certain problematic boards rather than
disabling dpm for the entire chip family since most
boards work fine.
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
Cc: stable@vger.kernel.org
---
drivers/gpu/drm/radeon/radeon_pm.c | 33 +++++++++++++++++++++++++++++++++
1 file changed, 33 insertions(+)
diff --git a/drivers/gpu/drm/radeon/radeon_pm.c b/drivers/gpu/drm/radeon/radeon_pm.c
index 32522cc..f7da8fe 100644
--- a/drivers/gpu/drm/radeon/radeon_pm.c
+++ b/drivers/gpu/drm/radeon/radeon_pm.c
@@ -1287,8 +1287,39 @@ dpm_failed:
return ret;
}
+struct radeon_dpm_quirk {
+ u32 chip_vendor;
+ u32 chip_device;
+ u32 subsys_vendor;
+ u32 subsys_device;
+};
+
+/* cards with dpm stability problems */
+static struct radeon_dpm_quirk radeon_dpm_quirk_list[] = {
+ /* TURKS - https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1386534 */
+ { PCI_VENDOR_ID_ATI, 0x6759, 0x1682, 0x3195 },
+ /* TURKS - https://bugzilla.kernel.org/show_bug.cgi?id=83731 */
+ { PCI_VENDOR_ID_ATI, 0x6840, 0x1179, 0xfb81 },
+ { 0, 0, 0, 0 },
+};
+
int radeon_pm_init(struct radeon_device *rdev)
{
+ struct radeon_dpm_quirk *p = radeon_dpm_quirk_list;
+ bool disable_dpm = false;
+
+ /* Apply dpm quirks */
+ while (p && p->chip_device != 0) {
+ if (rdev->pdev->vendor == p->chip_vendor &&
+ rdev->pdev->device == p->chip_device &&
+ rdev->pdev->subsystem_vendor == p->subsys_vendor &&
+ rdev->pdev->subsystem_device == p->subsys_device) {
+ disable_dpm = true;
+ break;
+ }
+ ++p;
+ }
+
/* enable dpm on rv6xx+ */
switch (rdev->family) {
case CHIP_RV610:
@@ -1344,6 +1375,8 @@ int radeon_pm_init(struct radeon_device *rdev)
(!(rdev->flags & RADEON_IS_IGP)) &&
(!rdev->smc_fw))
rdev->pm.pm_method = PM_METHOD_PROFILE;
+ else if (disable_dpm && (radeon_dpm == -1))
+ rdev->pm.pm_method = PM_METHOD_PROFILE;
else if (radeon_dpm == 0)
rdev->pm.pm_method = PM_METHOD_PROFILE;
else
--
1.8.3.1
^ permalink raw reply related [flat|nested] 9+ messages in thread
* Re: [Regression][v3.17][3.18][3.19-rc3] drm/radeon: re-enable dpm by default on BTC
2015-01-08 17:48 ` Deucher, Alexander
@ 2015-01-08 18:00 ` Joseph Salisbury
2015-01-08 21:58 ` Joseph Salisbury
1 sibling, 0 replies; 9+ messages in thread
From: Joseph Salisbury @ 2015-01-08 18:00 UTC (permalink / raw)
To: Deucher, Alexander
Cc: stable@vger.kernel.org, LKML, Koenig, Christian, David Airlie,
dri-devel
On 01/08/2015 12:48 PM, Deucher, Alexander wrote:
>> -----Original Message-----
>> From: Joseph Salisbury [mailto:joseph.salisbury@canonical.com]
>> Sent: Thursday, January 08, 2015 11:26 AM
>> To: Deucher, Alexander
>> Cc: stable@vger.kernel.org; LKML; Koenig, Christian; David Airlie; dri-devel
>> Subject: Re: [Regression][v3.17][3.18][3.19-rc3] drm/radeon: re-enable dpm
>> by default on BTC
>>
>> On 01/07/2015 09:51 PM, Deucher, Alexander wrote:
>>>> -----Original Message-----
>>>> From: Joseph Salisbury [mailto:joseph.salisbury@canonical.com]
>>>> Sent: Wednesday, January 07, 2015 5:51 PM
>>>> To: Deucher, Alexander
>>>> Cc: stable@vger.kernel.org; LKML; Koenig, Christian; David Airlie; dri-devel
>>>> Subject: [Regression][v3.17][3.18][3.19-rc3] drm/radeon: re-enable dpm
>> by
>>>> default on BTC
>>>>
>>>> Hi Alexander,
>>>>
>>>> A kernel bug report was opened against Ubuntu [0]. After a kernel
>>>> bisect, it was found that reverting the following commit resolved this bug:
>>>>
>>>> commit c08abf11900e19b14dd3a0cc3d105bd74519cd18
>>>> Author: Alex Deucher <alexander.deucher@amd.com>
>>>> Date: Mon Jul 14 12:01:40 2014 -0400
>>>>
>>>> drm/radeon: re-enable dpm by default on BTC
>>>>
>>>> The regression was introduced as of v3.17-rc1 and still exists in
>>>> current mainline. It has also made it's way into the stable releases.
>>>>
>>>> I was hoping to get your feedback, since you are the patch author. Do
>>>> you think gathering any additional data will help diagnose this issue,
>>>> or would it be best to submit a revert request?
>>>>
>>> Does revering b2dccf24e77 help? I'd hate to revert this patch because it
>> disables power management for a whole family of chips. If it doesn't help I'd
>> prefer to just add a quirk to disable it for the specific problematic board.
>> Commit b2dccf24e77 was added to mainline as of v3.18-rc1 and was not
>> cc'd to stable. We are also seeing this issue in the 3.13.y stable
>> kernel, which does not have commit b2dccf24e77 applied. However, we can
>> test reverting it in mainline?
> Nope. Won't make a difference. The attached patch adds a quirk list for dpm which will fix the issue for the affected boards.
>
> Alex
Great. Thanks so much for the assistance, Alex! I'll have the patch
tested and post some feedback.
>
>>> Alex
>>>
>>>> Thanks,
>>>>
>>>> Joe
>>>>
>>>> [0] http://pad.lv/1386534
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [Regression][v3.17][3.18][3.19-rc3] drm/radeon: re-enable dpm by default on BTC
2015-01-08 17:48 ` Deucher, Alexander
2015-01-08 18:00 ` Joseph Salisbury
@ 2015-01-08 21:58 ` Joseph Salisbury
2015-01-08 22:00 ` Deucher, Alexander
1 sibling, 1 reply; 9+ messages in thread
From: Joseph Salisbury @ 2015-01-08 21:58 UTC (permalink / raw)
To: Deucher, Alexander
Cc: stable@vger.kernel.org, LKML, Koenig, Christian, David Airlie,
dri-devel
On 01/08/2015 12:48 PM, Deucher, Alexander wrote:
>> -----Original Message-----
>> From: Joseph Salisbury [mailto:joseph.salisbury@canonical.com]
>> Sent: Thursday, January 08, 2015 11:26 AM
>> To: Deucher, Alexander
>> Cc: stable@vger.kernel.org; LKML; Koenig, Christian; David Airlie; dri-devel
>> Subject: Re: [Regression][v3.17][3.18][3.19-rc3] drm/radeon: re-enable dpm
>> by default on BTC
>>
>> On 01/07/2015 09:51 PM, Deucher, Alexander wrote:
>>>> -----Original Message-----
>>>> From: Joseph Salisbury [mailto:joseph.salisbury@canonical.com]
>>>> Sent: Wednesday, January 07, 2015 5:51 PM
>>>> To: Deucher, Alexander
>>>> Cc: stable@vger.kernel.org; LKML; Koenig, Christian; David Airlie; dri-devel
>>>> Subject: [Regression][v3.17][3.18][3.19-rc3] drm/radeon: re-enable dpm
>> by
>>>> default on BTC
>>>>
>>>> Hi Alexander,
>>>>
>>>> A kernel bug report was opened against Ubuntu [0]. After a kernel
>>>> bisect, it was found that reverting the following commit resolved this bug:
>>>>
>>>> commit c08abf11900e19b14dd3a0cc3d105bd74519cd18
>>>> Author: Alex Deucher <alexander.deucher@amd.com>
>>>> Date: Mon Jul 14 12:01:40 2014 -0400
>>>>
>>>> drm/radeon: re-enable dpm by default on BTC
>>>>
>>>> The regression was introduced as of v3.17-rc1 and still exists in
>>>> current mainline. It has also made it's way into the stable releases.
>>>>
>>>> I was hoping to get your feedback, since you are the patch author. Do
>>>> you think gathering any additional data will help diagnose this issue,
>>>> or would it be best to submit a revert request?
>>>>
>>> Does revering b2dccf24e77 help? I'd hate to revert this patch because it
>> disables power management for a whole family of chips. If it doesn't help I'd
>> prefer to just add a quirk to disable it for the specific problematic board.
>> Commit b2dccf24e77 was added to mainline as of v3.18-rc1 and was not
>> cc'd to stable. We are also seeing this issue in the 3.13.y stable
>> kernel, which does not have commit b2dccf24e77 applied. However, we can
>> test reverting it in mainline?
> Nope. Won't make a difference. The attached patch adds a quirk list for dpm which will fix the issue for the affected boards.
>
> Alex
Thanks again for the patch, Alex. The bug reporter has tested a 3.16
kernel with the patch and says it fixes the bug.
>
>>> Alex
>>>
>>>> Thanks,
>>>>
>>>> Joe
>>>>
>>>> [0] http://pad.lv/1386534
^ permalink raw reply [flat|nested] 9+ messages in thread
* RE: [Regression][v3.17][3.18][3.19-rc3] drm/radeon: re-enable dpm by default on BTC
2015-01-08 21:58 ` Joseph Salisbury
@ 2015-01-08 22:00 ` Deucher, Alexander
2015-01-08 22:11 ` Joseph Salisbury
0 siblings, 1 reply; 9+ messages in thread
From: Deucher, Alexander @ 2015-01-08 22:00 UTC (permalink / raw)
To: Joseph Salisbury
Cc: stable@vger.kernel.org, LKML, Koenig, Christian, David Airlie,
dri-devel
> -----Original Message-----
> From: Joseph Salisbury [mailto:joseph.salisbury@canonical.com]
> Sent: Thursday, January 08, 2015 4:58 PM
> To: Deucher, Alexander
> Cc: stable@vger.kernel.org; LKML; Koenig, Christian; David Airlie; dri-devel
> Subject: Re: [Regression][v3.17][3.18][3.19-rc3] drm/radeon: re-enable dpm
> by default on BTC
>
> On 01/08/2015 12:48 PM, Deucher, Alexander wrote:
> >> -----Original Message-----
> >> From: Joseph Salisbury [mailto:joseph.salisbury@canonical.com]
> >> Sent: Thursday, January 08, 2015 11:26 AM
> >> To: Deucher, Alexander
> >> Cc: stable@vger.kernel.org; LKML; Koenig, Christian; David Airlie; dri-devel
> >> Subject: Re: [Regression][v3.17][3.18][3.19-rc3] drm/radeon: re-enable
> dpm
> >> by default on BTC
> >>
> >> On 01/07/2015 09:51 PM, Deucher, Alexander wrote:
> >>>> -----Original Message-----
> >>>> From: Joseph Salisbury [mailto:joseph.salisbury@canonical.com]
> >>>> Sent: Wednesday, January 07, 2015 5:51 PM
> >>>> To: Deucher, Alexander
> >>>> Cc: stable@vger.kernel.org; LKML; Koenig, Christian; David Airlie; dri-
> devel
> >>>> Subject: [Regression][v3.17][3.18][3.19-rc3] drm/radeon: re-enable
> dpm
> >> by
> >>>> default on BTC
> >>>>
> >>>> Hi Alexander,
> >>>>
> >>>> A kernel bug report was opened against Ubuntu [0]. After a kernel
> >>>> bisect, it was found that reverting the following commit resolved this
> bug:
> >>>>
> >>>> commit c08abf11900e19b14dd3a0cc3d105bd74519cd18
> >>>> Author: Alex Deucher <alexander.deucher@amd.com>
> >>>> Date: Mon Jul 14 12:01:40 2014 -0400
> >>>>
> >>>> drm/radeon: re-enable dpm by default on BTC
> >>>>
> >>>> The regression was introduced as of v3.17-rc1 and still exists in
> >>>> current mainline. It has also made it's way into the stable releases.
> >>>>
> >>>> I was hoping to get your feedback, since you are the patch author. Do
> >>>> you think gathering any additional data will help diagnose this issue,
> >>>> or would it be best to submit a revert request?
> >>>>
> >>> Does revering b2dccf24e77 help? I'd hate to revert this patch because it
> >> disables power management for a whole family of chips. If it doesn't help
> I'd
> >> prefer to just add a quirk to disable it for the specific problematic board.
> >> Commit b2dccf24e77 was added to mainline as of v3.18-rc1 and was not
> >> cc'd to stable. We are also seeing this issue in the 3.13.y stable
> >> kernel, which does not have commit b2dccf24e77 applied. However, we
> can
> >> test reverting it in mainline?
> > Nope. Won't make a difference. The attached patch adds a quirk list for
> dpm which will fix the issue for the affected boards.
> >
> > Alex
> Thanks again for the patch, Alex. The bug reporter has tested a 3.16
> kernel with the patch and says it fixes the bug.
I'll queue it up for 3.19-fixes and cc stable.
Thanks,
Alex
>
>
> >
> >>> Alex
> >>>
> >>>> Thanks,
> >>>>
> >>>> Joe
> >>>>
> >>>> [0] http://pad.lv/1386534
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [Regression][v3.17][3.18][3.19-rc3] drm/radeon: re-enable dpm by default on BTC
2015-01-08 22:00 ` Deucher, Alexander
@ 2015-01-08 22:11 ` Joseph Salisbury
0 siblings, 0 replies; 9+ messages in thread
From: Joseph Salisbury @ 2015-01-08 22:11 UTC (permalink / raw)
To: Deucher, Alexander
Cc: stable@vger.kernel.org, LKML, Koenig, Christian, David Airlie,
dri-devel
On 01/08/2015 05:00 PM, Deucher, Alexander wrote:
>> -----Original Message-----
>> From: Joseph Salisbury [mailto:joseph.salisbury@canonical.com]
>> Sent: Thursday, January 08, 2015 4:58 PM
>> To: Deucher, Alexander
>> Cc: stable@vger.kernel.org; LKML; Koenig, Christian; David Airlie; dri-devel
>> Subject: Re: [Regression][v3.17][3.18][3.19-rc3] drm/radeon: re-enable dpm
>> by default on BTC
>>
>> On 01/08/2015 12:48 PM, Deucher, Alexander wrote:
>>>> -----Original Message-----
>>>> From: Joseph Salisbury [mailto:joseph.salisbury@canonical.com]
>>>> Sent: Thursday, January 08, 2015 11:26 AM
>>>> To: Deucher, Alexander
>>>> Cc: stable@vger.kernel.org; LKML; Koenig, Christian; David Airlie; dri-devel
>>>> Subject: Re: [Regression][v3.17][3.18][3.19-rc3] drm/radeon: re-enable
>> dpm
>>>> by default on BTC
>>>>
>>>> On 01/07/2015 09:51 PM, Deucher, Alexander wrote:
>>>>>> -----Original Message-----
>>>>>> From: Joseph Salisbury [mailto:joseph.salisbury@canonical.com]
>>>>>> Sent: Wednesday, January 07, 2015 5:51 PM
>>>>>> To: Deucher, Alexander
>>>>>> Cc: stable@vger.kernel.org; LKML; Koenig, Christian; David Airlie; dri-
>> devel
>>>>>> Subject: [Regression][v3.17][3.18][3.19-rc3] drm/radeon: re-enable
>> dpm
>>>> by
>>>>>> default on BTC
>>>>>>
>>>>>> Hi Alexander,
>>>>>>
>>>>>> A kernel bug report was opened against Ubuntu [0]. After a kernel
>>>>>> bisect, it was found that reverting the following commit resolved this
>> bug:
>>>>>> commit c08abf11900e19b14dd3a0cc3d105bd74519cd18
>>>>>> Author: Alex Deucher <alexander.deucher@amd.com>
>>>>>> Date: Mon Jul 14 12:01:40 2014 -0400
>>>>>>
>>>>>> drm/radeon: re-enable dpm by default on BTC
>>>>>>
>>>>>> The regression was introduced as of v3.17-rc1 and still exists in
>>>>>> current mainline. It has also made it's way into the stable releases.
>>>>>>
>>>>>> I was hoping to get your feedback, since you are the patch author. Do
>>>>>> you think gathering any additional data will help diagnose this issue,
>>>>>> or would it be best to submit a revert request?
>>>>>>
>>>>> Does revering b2dccf24e77 help? I'd hate to revert this patch because it
>>>> disables power management for a whole family of chips. If it doesn't help
>> I'd
>>>> prefer to just add a quirk to disable it for the specific problematic board.
>>>> Commit b2dccf24e77 was added to mainline as of v3.18-rc1 and was not
>>>> cc'd to stable. We are also seeing this issue in the 3.13.y stable
>>>> kernel, which does not have commit b2dccf24e77 applied. However, we
>> can
>>>> test reverting it in mainline?
>>> Nope. Won't make a difference. The attached patch adds a quirk list for
>> dpm which will fix the issue for the affected boards.
>>> Alex
>> Thanks again for the patch, Alex. The bug reporter has tested a 3.16
>> kernel with the patch and says it fixes the bug.
> I'll queue it up for 3.19-fixes and cc stable.
Great. Thanks, again!
> Thanks,
>
> Alex
>
>>
>>>>> Alex
>>>>>
>>>>>> Thanks,
>>>>>>
>>>>>> Joe
>>>>>>
>>>>>> [0] http://pad.lv/1386534
^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2015-01-08 22:11 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-01-07 22:51 [Regression][v3.17][3.18][3.19-rc3] drm/radeon: re-enable dpm by default on BTC Joseph Salisbury
2015-01-08 2:51 ` Deucher, Alexander
2015-01-08 16:12 ` Joseph Salisbury
2015-01-08 16:25 ` Joseph Salisbury
2015-01-08 17:48 ` Deucher, Alexander
2015-01-08 18:00 ` Joseph Salisbury
2015-01-08 21:58 ` Joseph Salisbury
2015-01-08 22:00 ` Deucher, Alexander
2015-01-08 22:11 ` Joseph Salisbury
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).