From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Message-ID: <54C85454.6070303@cn.fujitsu.com> Date: Wed, 28 Jan 2015 11:15:32 +0800 From: Lai Jiangshan MIME-Version: 1.0 To: Tejun Heo CC: Greg Kroah-Hartman , , , Eric Sandeen , Dave Chinner Subject: Re: [PATCH 3.18 11/61] workqueue: fix subtle pool management issue which can stall whole worker_pool References: <20150128012636.936333725@linuxfoundation.org> <20150128012638.187292688@linuxfoundation.org> <54C840BA.7020207@cn.fujitsu.com> <20150128022456.GF12314@htj.dyndns.org> In-Reply-To: <20150128022456.GF12314@htj.dyndns.org> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: On 01/28/2015 10:24 AM, Tejun Heo wrote: > On Wed, Jan 28, 2015 at 09:51:54AM +0800, Lai Jiangshan wrote: >> On 01/28/2015 09:26 AM, Greg Kroah-Hartman wrote: >>> 3.18-stable review patch. If anyone has any objections, please let me know. >> >> >> I don't think it is a bug-fix. >> It is just a good cleanup. > > It is a bug fix, for a rare but potentially critical issue. Please > read the patch description. It contains ample information on what's > broken and also the link to the original bug report. > Sorry, you are right. Was the bug introduced at the first time when maybe_create_worker() was introduced? Although manage_workers()/maybe_create_worker() was changed a bit, the stable-tree team can simply make manage_workers() return true to fix this bug for the very old kernel versions.