From: David Ahern <dsahern@gmail.com>
To: Steven Rostedt <rostedt@goodmis.org>,
James Hogan <james.hogan@imgtec.com>
Cc: Jeff Layton <jlayton@primarydata.com>,
"J. Bruce Fields" <bfields@redhat.com>,
linux-kernel@vger.kernel.org,
Trond Myklebust <trond.myklebust@primarydata.com>,
Ingo Molnar <mingo@redhat.com>,
stable@vger.kernel.org
Subject: Re: [PATCH] sunrpc: Fix trace events to store data in the struct
Date: Tue, 24 Feb 2015 09:03:09 -0700 [thread overview]
Message-ID: <54ECA0BD.8010004@gmail.com> (raw)
In-Reply-To: <20150224094848.36dc2c88@gandalf.local.home>
On 2/24/15 7:48 AM, Steven Rostedt wrote:
> I assume that the %pISpc expects a "struct sockaddr" passed to it as
> that is what is typecast in the print. We might as well make the ss into
> that structure instead of a struct sockaddr_storage, as it looks like
> the storage one is much larger, and we only care about the sockaddr
> part. Let's not waste the ring buffer if we don't need to.
Per lib/vsprintf.c, it expects either a sockaddr_in or sockaddr_in6:
case 'S': {
const union {
struct sockaddr raw;
struct sockaddr_in v4;
struct sockaddr_in6 v6;
} *sa = ptr;
sockaddr_in6 > sockaddr so ss should be declared accordingly.
David
next prev parent reply other threads:[~2015-02-24 16:03 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-24 11:47 [PATCH] sunrpc: Fix trace events to store data in the struct James Hogan
2015-02-24 13:36 ` Trond Myklebust
2015-02-24 13:46 ` James Hogan
2015-02-24 14:49 ` Steven Rostedt
2015-02-24 14:09 ` Steven Rostedt
2015-02-24 14:19 ` James Hogan
2015-02-24 14:48 ` Steven Rostedt
2015-02-24 16:03 ` David Ahern [this message]
2015-02-24 16:07 ` Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54ECA0BD.8010004@gmail.com \
--to=dsahern@gmail.com \
--cc=bfields@redhat.com \
--cc=james.hogan@imgtec.com \
--cc=jlayton@primarydata.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=rostedt@goodmis.org \
--cc=stable@vger.kernel.org \
--cc=trond.myklebust@primarydata.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox