Re: [PATCH 6.1 00/81] 6.1.144-rc2 review

[Niklas Schnelle <schnelle@linux.ibm.com>]

On Thu, 2025-07-10 at 01:34 +0530, Naresh Kamboju wrote:
> On Tue, 8 Jul 2025 at 23:40, Greg Kroah-Hartman
> <gregkh@linuxfoundation.org> wrote:
> > 
> > This is the start of the stable review cycle for the 6.1.144 release.
> > There are 81 patches in this series, all will be posted as a response
> > to this one.  If anyone has any issues with these being applied, please
> > let me know.
> > 
> > Responses should be made by Thu, 10 Jul 2025 18:08:50 +0000.
> > Anything received after that time might be too late.
> > 
> > The whole patch series can be found in one patch at:
> >         https://www.kernel.org/pub/linux/kernel/v6.x/stable-review/patch-6.1.144-rc2.gz
> > or in the git tree and branch at:
> >         git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-6.1.y
> > and the diffstat can be found below.
> > 
> > thanks,
> > 
> > greg k-h
> 
> 
> Regression on the stable-rc 6.1.144-rc2 s390 builds failed with clang-20
> 
--- snip ---
> 
> in 'struct zpci_dev'
>   285 |                 mutex_unlock(&zdev->state_lock);
>       |                               ~~~~  ^
> 4 errors generated.
> 
> ## Source
> * Kernel version: 6.1.144-rc2
> 

Hi Naresh, Hi Greg,

Thanks for the report! 

Looks like the backport of 45537926dd2a ("s390/pci: Fix stale function
handles in error handling") is broken. In the original commit there is
a context line mutex_lock(&zdev->state_lock) from commit bcb5d6c76903
("s390/pci: introduce lock to synchronize state of zpci_dev's") that
ended up in the stable tree without also pulling in the rest of that
commit. I found that backport in my mail and not only is the context
turned into added lines but it also adds the matching unlock in the
wrong place. Will comment on that mail too.

Thanks,
Niklas