From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from aserp1040.oracle.com ([141.146.126.69]:47864 "EHLO aserp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752288AbbD0DRu (ORCPT ); Sun, 26 Apr 2015 23:17:50 -0400 Message-ID: <553DAA5A.6060000@oracle.com> Date: Sun, 26 Apr 2015 23:17:46 -0400 From: Sasha Levin MIME-Version: 1.0 To: Guenter Roeck , stable Subject: Re: v3.18-stable-queue build failures References: <553CBE54.7060303@roeck-us.net> In-Reply-To: <553CBE54.7060303@roeck-us.net> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Sender: stable-owner@vger.kernel.org List-ID: On 04/26/2015 06:30 AM, Guenter Roeck wrote: > Hi, > > almost all builds in v3.18-stable-queue fail with > > In file included from net/socket.c:74:0: > include/linux/if_vlan.h: In function 'vlan_put_tag': > include/linux/if_vlan.h:409:3: error: implicit declaration of function '__vlan_put_tag' [-Werror=implicit-function-declaration] > include/linux/if_vlan.h:409:3: warning: return makes pointer from integer without a cast [enabled by default] > > groeck@server:~/src/linux-stable$ git grep __vlan_put_tag > include/linux/if_vlan.h: return __vlan_put_tag(skb, vlan_proto, vlan_tci); > > It appears that 'vlan: rename __vlan_put_tag to vlan_insert_tag_set_proto' was incomplete > for v3.18. Thanks! This was actually missing b4bef1b575 ("vlan: kill vlan_put_tag helper"). Fixed and re-pushed. Thanks, Sasha