From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from e31.co.us.ibm.com ([32.97.110.149]:59806 "EHLO e31.co.us.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750774AbbEKFuX (ORCPT ); Mon, 11 May 2015 01:50:23 -0400 Received: from /spool/local by e31.co.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Sun, 10 May 2015 23:50:23 -0600 Received: from b03cxnp07028.gho.boulder.ibm.com (b03cxnp07028.gho.boulder.ibm.com [9.17.130.15]) by d03dlp03.boulder.ibm.com (Postfix) with ESMTP id B68CB19D803E for ; Sun, 10 May 2015 23:41:23 -0600 (MDT) Received: from d03av04.boulder.ibm.com (d03av04.boulder.ibm.com [9.17.195.170]) by b03cxnp07028.gho.boulder.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id t4B5mG3T30146700 for ; Sun, 10 May 2015 22:48:16 -0700 Received: from d03av04.boulder.ibm.com (loopback [127.0.0.1]) by d03av04.boulder.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id t4B5oJIf012934 for ; Sun, 10 May 2015 23:50:20 -0600 Message-ID: <55504319.9090501@linux.vnet.ibm.com> Date: Mon, 11 May 2015 11:20:17 +0530 From: Preeti U Murthy MIME-Version: 1.0 To: Guenter Roeck , stable , Greg Kroah-Hartman CC: Ingo Molnar Subject: Re: 4.0.2-stable-queue build failures due to 'clockevents: Fix cpu_down() race for hrtimer based broadcasting' References: <554FFEED.6030308@roeck-us.net> In-Reply-To: <554FFEED.6030308@roeck-us.net> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Sender: stable-owner@vger.kernel.org List-ID: On 05/11/2015 06:29 AM, Guenter Roeck wrote: > Build is still going on, so there may be other affected architectures. > > --- > > Building ia64:defconfig ... failed > Building parisc:generic-32bit_defconfig ... failed > -------------- > Error log: > kernel/cpu.c: In function '_cpu_down': > kernel/cpu.c:415:2: error: implicit declaration of function > 'hotplug_cpu__broadcast_tick_pull' [-Werror=implicit-function-declaration] > cc1: some warnings being treated as errors > > --- > > Bisect log: > > # bad: [c71309a3658d323d56261d4590b2c5214e61b05f] clockevents: Fix > cpu_down() race for hrtimer based broadcasting > # good: [072cab659c9368586d6417cfd6ec2d2c68469c67] Linux 4.0.2 > git bisect start 'HEAD' 'v4.0.2' > # good: [7e62c9a30d01ac14be2bc3e048b737e1b0c8d08d] cdc-acm: prevent > infinite loop when parsing CDC headers. > git bisect good 7e62c9a30d01ac14be2bc3e048b737e1b0c8d08d > # good: [8b55f847f1e9964ac2ab657cc0e1334ed8be214c] ext4: fix data > corruption caused by unwritten and delayed extents > git bisect good 8b55f847f1e9964ac2ab657cc0e1334ed8be214c > # good: [7c0e04a5e08bec7f9101d20214f92b5f466a556b] drm/radeon: only mark > audio as connected if the monitor supports it (v3) > git bisect good 7c0e04a5e08bec7f9101d20214f92b5f466a556b > # good: [da9778d808f0629fd804421e97294f25b81b1885] drm/radeon: fix > lockup when BOs aren't part of the VM on release > git bisect good da9778d808f0629fd804421e97294f25b81b1885 > # good: [68cd28ab24ce16ac7f3978a7627eae5b599c3d8b] drm/radeon: check new > address before removing old one > git bisect good 68cd28ab24ce16ac7f3978a7627eae5b599c3d8b > # good: [c20b6545f649724a733e008e7124fa9d1e114c71] Drivers: hv: vmbus: > Don't wait after requesting offers > git bisect good c20b6545f649724a733e008e7124fa9d1e114c71 > # first bad commit: [c71309a3658d323d56261d4590b2c5214e61b05f] > clockevents: Fix cpu_down() race for hrtimer based broadcasting > > --- > > Reverting the bad commit fixes the problem. Please let me know if the following patch fixes the issue: clockevents: Fix build error caused by fix for hotplug race with hrtimer broadcast commit: c71309a3658d ("clockevents: Fix cpu_down() race for hrtimer based broadcasting") causes a build error on certain archs where CONFIG_GENERIC_CLOCKEVENTS is not set. This patch fixes this. Signed-off-by: Preeti U. Murthy diff --git a/include/linux/tick.h b/include/linux/tick.h index e3e9d20..b62ff06 100644 --- a/include/linux/tick.h +++ b/include/linux/tick.h @@ -134,6 +134,7 @@ static inline void tick_clock_notify(void) { } static inline int tick_check_oneshot_change(int allow_nohz) { return 0; } static inline void tick_irq_enter(void) { } static inline int tick_oneshot_mode_active(void) { return 0; } +static inline void hotplug_cpu__broadcast_tick_pull(int dead_cpu) { } #endif /* !CONFIG_GENERIC_CLOCKEVENTS */ # ifdef CONFIG_NO_HZ_COMMON Thanks Regards Preeti U Murthy > > Guenter >