From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <stable-owner@vger.kernel.org>
Received: from mail-pa0-f42.google.com ([209.85.220.42]:34277 "EHLO
	mail-pa0-f42.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1751090AbbENOkj (ORCPT
	<rfc822;stable@vger.kernel.org>); Thu, 14 May 2015 10:40:39 -0400
Received: by pacyx8 with SMTP id yx8so87876430pac.1
        for <stable@vger.kernel.org>; Thu, 14 May 2015 07:40:38 -0700 (PDT)
Message-ID: <5554B3E3.6090407@linaro.org>
Date: Thu, 14 May 2015 22:40:35 +0800
From: Alex Shi <alex.shi@linaro.org>
MIME-Version: 1.0
To: Dmitry Monakhov <dmonakhov@openvz.org>,
	Theodore Ts'o <tytso@mit.edu>, Jan Kara <jack@suse.cz>,
	Linaro Kernel <linaro-kernel@lists.linaro.org>
CC: stable@vger.kernel.org
Subject: a old issue of ext4 on lts 3.10
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Sender: stable-owner@vger.kernel.org
List-ID: <stable.vger.kernel.org>

Hi Dmitry&Theodore,

Someone said without the following patch on lts 3.10 kernel (which used
as android base kernel). the write maybe very very slow, needs 1 or 2
seconds to finish.

I quick looked this patch, seems it's no harm for a normal fs function.
but still don't know why it is helpful. So do you remember why you
commit this change at that time?

Thanks
Alex

ommit 7afe5aa59ed3da7b6161617e7f157c7c680dc41e
Author: Dmitry Monakhov <dmonakhov@openvz.org>
Date:   Wed Aug 28 14:30:47 2013 -0400

    ext4: convert write_begin methods to stable_page_writes semantics

    Use wait_for_stable_page() instead of wait_on_page_writeback()

    Signed-off-by: Dmitry Monakhov <dmonakhov@openvz.org>
    Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
    Reviewed-by: Jan Kara <jack@suse.cz>

diff --git a/fs/ext4/inode.c b/fs/ext4/inode.c
index fc4051e..47c8e46 100644
--- a/fs/ext4/inode.c
+++ b/fs/ext4/inode.c
@@ -969,7 +969,8 @@ retry_journal:
                ext4_journal_stop(handle);
                goto retry_grab;
        }
-       wait_on_page_writeback(page);
+       /* In case writeback began while the page was unlocked */
+       wait_for_stable_page(page);

        if (ext4_should_dioread_nolock(inode))
                ret = __block_write_begin(page, pos, len,
ext4_get_block_write);
@@ -2678,7 +2679,7 @@ retry_journal:
                goto retry_grab;
        }
        /* In case writeback began while the page was unlocked */
-       wait_on_page_writeback(page);
+       wait_for_stable_page(page);

        ret = __block_write_begin(page, pos, len, ext4_da_get_block_prep);
        if (ret < 0) {
~

-- 
Thanks
    Alex