From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com ([209.132.183.28]:34206 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932803AbbFWOjY (ORCPT ); Tue, 23 Jun 2015 10:39:24 -0400 Message-ID: <55896F97.403@redhat.com> Date: Tue, 23 Jun 2015 16:39:19 +0200 From: Paolo Bonzini MIME-Version: 1.0 To: Christian Borntraeger CC: Alexander Graf , KVM , Cornelia Huck , Jens Freimann , linux-s390 , stable@vger.kernel.org, #@tuxmaker.boeblingen.de.ibm.com, 4.1@tuxmaker.boeblingen.de.ibm.com Subject: Re: [PATCH 1/1] KVM: s390: clear floating interrupt bitmap and parameters References: <1434972012-68554-1-git-send-email-borntraeger@de.ibm.com> <1434972012-68554-2-git-send-email-borntraeger@de.ibm.com> In-Reply-To: <1434972012-68554-2-git-send-email-borntraeger@de.ibm.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: stable-owner@vger.kernel.org List-ID: On 22/06/2015 13:20, Christian Borntraeger wrote: > From: Jens Freimann > > commit 6d3da24141 ("KVM: s390: deliver floating interrupts in order > of priority") introduced a regression for the reset handling. > > We don't clear the bitmap of pending floating interrupts > and interrupt parameters. This could result in stale interrupts > even after a reset. Let's fix this by clearing the pending bitmap > and the parameters for service and machine check interrupts. > > Cc: stable@vger.kernel.org # 4.1 > Signed-off-by: Jens Freimann > Signed-off-by: Christian Borntraeger > --- > arch/s390/kvm/interrupt.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/arch/s390/kvm/interrupt.c b/arch/s390/kvm/interrupt.c > index 322ef9c..480b975 100644 > --- a/arch/s390/kvm/interrupt.c > +++ b/arch/s390/kvm/interrupt.c > @@ -1621,6 +1621,9 @@ void kvm_s390_clear_float_irqs(struct kvm *kvm) > int i; > > spin_lock(&fi->lock); > + fi->pending_irqs = 0; > + memset(&fi->srv_signal, 0, sizeof(fi->srv_signal)); > + memset(&fi->mchk, 0, sizeof(fi->mchk)); > for (i = 0; i < FIRQ_LIST_COUNT; i++) > clear_irq_list(&fi->lists[i]); > for (i = 0; i < FIRQ_MAX_COUNT; i++) > Applied, thanks. Paolo