From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=100.103.45.18 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1794908632; b=4rgUyjB/JZ9lUqmytoFzI6Hfc2PCHfgPZ2/rCdT2BIsRqPjbILKOzvEBST9NRxBA5Me7 jG8jedMY3anz6Edo4OYIZIazAS2ViNN4ItqZWy8pL2L3fBo5HO3LAq/FoXfKeYCGU1Y94 XYLzTfauY6BU+Yr0kvjzGWG/ElgNFCyVU7ae3tuJZSQf2uB9TFV7iRJjpjkx69mJ/ZU50 TxC9mvxB9KHJQ1waSHGIpdUjjdKta+iTvimUU0RgVqnN8Px24lZF3c11YA+mDgUiAs9q6 AbG6kI+Hn9ezrZz7eb3EGUxPd38ihbLXByKg7egDqPk8edPDm3r0VC8rdLdT0z9AXsg== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1794908632; h=Received:DKIM-Signature:Message-ID:Date:MIME-Version:User-Agent: Subject:To:Cc:References:From:Content-Language:Autocrypt:In-Reply-To: Content-Type:Content-Transfer-Encoding; bh=U8Uuy//B8VLhVUEAfNen2OqeBRsqmMAJ6ktOCeoG89w=; b=CBXYB84rpc2QZGSvxN6vBCpZwTS8NmYdsfXdriudvIIvQ0We0ts+UmWxFHg4XiotV88z A7TMKA/V3nbm7tTapfZU33o/N4HD/BjI59tXcHro0POvB0tDs9BNWqZ3sI5i5rLyD7GOk Q6j2HYJELK4w8I+UsgRY9BelFGe3n7cxAu8LzlhhTMPYodUKljkExKS1JwSr9HsDZ6pOL Ywdq7hLE3AYxSxGnbXmQeFNxm3gDuPiZO107A3MTszkfSXmV7ip5wcyQZ9dIAzXqWnYxZ pMcdx7GgrgSBho/hbxz4O43d5spYmRdFIqE6KEihJjQvRT6epRyULvm+C2cCJntqfEw== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20260515 header.b=CmAX2rVy; arc=none smtp.remote-ip=100.103.45.18 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F1CFC606A8BB; Tue, 17 Nov 2026 09:43:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20260515 header.b=CmAX2rVy Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7AB931F01819; Tue, 17 Nov 2026 09:43:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1794908631; bh=U8Uuy//B8VLhVUEAfNen2OqeBRsqmMAJ6ktOCeoG89w=; h=Date:Subject:To:Cc:References:From:In-Reply-To; b=CmAX2rVyN+dOqJ+NLX4LjVjwKCXCFMSaLbnZ8h1DpHG3wM0ioWSiviVFsIXYifxt+ 8ANiBw6z296xRRNmUI0ToOpH1ne8GxIXmR4KLvbq/EQW4ykJPj+p6WZFASCClLs1o3 ndkIrgA6/jOVyznXW+C0SZ196uf+VlZFxxRuH0TbXXTdVUEmzk0d8m1i14utDslwNI ZneMfO99B2ELp4e6MtULSOIeeRDYu2wTijkM5La2vPbVzxp8DHNLq+Q5N0xJXsZHQX r3vwzKJdg8/qUgQjiyt2FGnvpTwWfKyasBQ8xIHnzzrFvTA57v92bFkKFJoE5VfD8x BPXNNKXde286A== Message-ID: <558f6c84-84d6-4029-8199-46d4e07c8c0a@kernel.org> Date: Tue, 17 Nov 2026 10:43:45 +0100 X-Mailing-List: stable@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v5 2/3] mm: gup: allow long-term pins of CMA-allocated HugeTLB folios To: Qi Zheng , muchun.song@linux.dev, osalvador@suse.de, akpm@linux-foundation.org, azpijr@gmail.com, lance.yang@linux.dev, fvdl@google.com Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, Qi Zheng , stable@vger.kernel.org References: <295af6601ce79f2c2b3dc4352a3279f0e6ac513e.1794907279.git.zhengqi.arch@bytedance.com> From: "David Hildenbrand (Arm)" Content-Language: en-US Autocrypt: addr=david@kernel.org; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzS5EYXZpZCBIaWxk ZW5icmFuZCAoQ3VycmVudCkgPGRhdmlkQGtlcm5lbC5vcmc+wsGQBBMBCAA6AhsDBQkmWAik AgsJBBUKCQgCFgICHgUCF4AWIQQb2cqtc1xMOkYN/MpN3hD3AP+DWgUCaYJt/AIZAQAKCRBN 3hD3AP+DWriiD/9BLGEKG+N8L2AXhikJg6YmXom9ytRwPqDgpHpVg2xdhopoWdMRXjzOrIKD g4LSnFaKneQD0hZhoArEeamG5tyo32xoRsPwkbpIzL0OKSZ8G6mVbFGpjmyDLQCAxteXCLXz ZI0VbsuJKelYnKcXWOIndOrNRvE5eoOfTt2XfBnAapxMYY2IsV+qaUXlO63GgfIOg8RBaj7x 3NxkI3rV0SHhI4GU9K6jCvGghxeS1QX6L/XI9mfAYaIwGy5B68kF26piAVYv/QZDEVIpo3t7 /fjSpxKT8plJH6rhhR0epy8dWRHk3qT5tk2P85twasdloWtkMZ7FsCJRKWscm1BLpsDn6EQ4 jeMHECiY9kGKKi8dQpv3FRyo2QApZ49NNDbwcR0ZndK0XFo15iH708H5Qja/8TuXCwnPWAcJ DQoNIDFyaxe26Rx3ZwUkRALa3iPcVjE0//TrQ4KnFf+lMBSrS33xDDBfevW9+Dk6IISmDH1R HFq2jpkN+FX/PE8eVhV68B2DsAPZ5rUwyCKUXPTJ/irrCCmAAb5Jpv11S7hUSpqtM/6oVESC 3z/7CzrVtRODzLtNgV4r5EI+wAv/3PgJLlMwgJM90Fb3CB2IgbxhjvmB1WNdvXACVydx55V7 LPPKodSTF29rlnQAf9HLgCphuuSrrPn5VQDaYZl4N/7zc2wcWM7BTQRVy5+RARAA59fefSDR 9nMGCb9LbMX+TFAoIQo/wgP5XPyzLYakO+94GrgfZjfhdaxPXMsl2+o8jhp/hlIzG56taNdt VZtPp3ih1AgbR8rHgXw1xwOpuAd5lE1qNd54ndHuADO9a9A0vPimIes78Hi1/yy+ZEEvRkHk /kDa6F3AtTc1m4rbbOk2fiKzzsE9YXweFjQvl9p+AMw6qd/iC4lUk9g0+FQXNdRs+o4o6Qvy iOQJfGQ4UcBuOy1IrkJrd8qq5jet1fcM2j4QvsW8CLDWZS1L7kZ5gT5EycMKxUWb8LuRjxzZ 3QY1aQH2kkzn6acigU3HLtgFyV1gBNV44ehjgvJpRY2cC8VhanTx0dZ9mj1YKIky5N+C0f21 zvntBqcxV0+3p8MrxRRcgEtDZNav+xAoT3G0W4SahAaUTWXpsZoOecwtxi74CyneQNPTDjNg azHmvpdBVEfj7k3p4dmJp5i0U66Onmf6mMFpArvBRSMOKU9DlAzMi4IvhiNWjKVaIE2Se9BY FdKVAJaZq85P2y20ZBd08ILnKcj7XKZkLU5FkoA0udEBvQ0f9QLNyyy3DZMCQWcwRuj1m73D sq8DEFBdZ5eEkj1dCyx+t/ga6x2rHyc8Sl86oK1tvAkwBNsfKou3v+jP/l14a7DGBvrmlYjO 59o3t6inu6H7pt7OL6u6BQj7DoMAEQEAAcLBfAQYAQgAJgIbDBYhBBvZyq1zXEw6Rg38yk3e EPcA/4NaBQJonNqrBQkmWAihAAoJEE3eEPcA/4NaKtMQALAJ8PzprBEXbXcEXwDKQu+P/vts IfUb1UNMfMV76BicGa5NCZnJNQASDP/+bFg6O3gx5NbhHHPeaWz/VxlOmYHokHodOvtL0WCC 8A5PEP8tOk6029Z+J+xUcMrJClNVFpzVvOpb1lCbhjwAV465Hy+NUSbbUiRxdzNQtLtgZzOV Zw7jxUCs4UUZLQTCuBpFgb15bBxYZ/BL9MbzxPxvfUQIPbnzQMcqtpUs21CMK2PdfCh5c4gS sDci6D5/ZIBw94UQWmGpM/O1ilGXde2ZzzGYl64glmccD8e87OnEgKnH3FbnJnT4iJchtSvx yJNi1+t0+qDti4m88+/9IuPqCKb6Stl+s2dnLtJNrjXBGJtsQG/sRpqsJz5x1/2nPJSRMsx9 5YfqbdrJSOFXDzZ8/r82HgQEtUvlSXNaXCa95ez0UkOG7+bDm2b3s0XahBQeLVCH0mw3RAQg r7xDAYKIrAwfHHmMTnBQDPJwVqxJjVNr7yBic4yfzVWGCGNE4DnOW0vcIeoyhy9vnIa3w1uZ 3iyY2Nsd7JxfKu1PRhCGwXzRw5TlfEsoRI7V9A8isUCoqE2Dzh3FvYHVeX4Us+bRL/oqareJ CIFqgYMyvHj7Q06kTKmauOe4Nf0l0qEkIuIzfoLJ3qr5UyXc2hLtWyT9Ir+lYlX9efqh7mOY qIws/H2t In-Reply-To: <295af6601ce79f2c2b3dc4352a3279f0e6ac513e.1794907279.git.zhengqi.arch@bytedance.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 11/17/26 10:33, Qi Zheng wrote: > From: Qi Zheng > > Long-term pinning rejects HugeTLB folios explicitly allocated from CMA, > causing unnecessary migration or pinning failures. These folios already > own their CMA memory and do not need to be migrated out for future CMA > allocations. > > Add cma_folio_is_longterm_pinnable() to recognize these allocations > through HPG_cma. Allow them to be pinned even in ZONE_MOVABLE, since > memory blocks overlapping boot-time CMA areas cannot be offlined. Ordinary > movable allocations that borrow CMA memory remain unpinnable. > > Fixes: cf11e85fc08c ("mm: hugetlb: optionally allocate gigantic hugepages using cma") > Cc: stable@vger.kernel.org > Suggested-by: Muchun Song > Suggested-by: David Hildenbrand (Arm) > Signed-off-by: Qi Zheng > Acked-by: Muchun Song > Reviewed-by: Oscar Salvador > Reviewed-by: Jose A. Perez de Azpillaga > Reviewed-by: Frank van der Linden > --- > include/linux/cma.h | 3 +++ > include/linux/mm.h | 9 ++++++--- > mm/cma.c | 11 +++++++++++ > 3 files changed, 20 insertions(+), 3 deletions(-) > > diff --git a/include/linux/cma.h b/include/linux/cma.h > index 8555d38a97b1a..d829fd0355bae 100644 > --- a/include/linux/cma.h > +++ b/include/linux/cma.h > @@ -21,6 +21,9 @@ > #define CMA_MIN_ALIGNMENT_BYTES (PAGE_SIZE * CMA_MIN_ALIGNMENT_PAGES) > > struct cma; > +struct folio; > + > +bool cma_folio_is_longterm_pinnable(struct folio *folio); > > extern unsigned long totalcma_pages; > extern phys_addr_t cma_get_base(const struct cma *cma); > diff --git a/include/linux/mm.h b/include/linux/mm.h > index daf5c5b567ebc..e71aae8001831 100644 > --- a/include/linux/mm.h > +++ b/include/linux/mm.h > @@ -38,6 +38,7 @@ > #include > #include > #include > +#include > > struct mempolicy; > struct anon_vma; > @@ -3015,15 +3016,18 @@ static inline bool is_zero_folio(const struct folio *folio) > return is_zero_page(&folio->page); > } > > -/* MIGRATE_CMA and ZONE_MOVABLE do not allow pin folios */ > #ifdef CONFIG_MIGRATION > +/* > + * MIGRATE_CMA and ZONE_MOVABLE folios cannot normally be long-term pinned. > + * CMA may allow pinning folios explicitly allocated from its areas. > + */ > static inline bool folio_is_longterm_pinnable(struct folio *folio) > { > #ifdef CONFIG_CMA > int mt = folio_migratetype(folio); > > if (mt == MIGRATE_CMA || mt == MIGRATE_ISOLATE) > - return false; > + return cma_folio_is_longterm_pinnable(folio); > #endif > /* The zero page can be "pinned" but gets special handling. */ > if (is_zero_folio(folio)) > @@ -3042,7 +3046,6 @@ static inline bool folio_is_longterm_pinnable(struct folio *folio) > > /* Otherwise, non-movable zone folios can be pinned. */ > return !folio_is_zone_movable(folio); > - > } > #else > static inline bool folio_is_longterm_pinnable(struct folio *folio) > diff --git a/mm/cma.c b/mm/cma.c > index 9ec1d1fd5dff5..fea5d1015319d 100644 > --- a/mm/cma.c > +++ b/mm/cma.c > @@ -29,6 +29,7 @@ > #include > #include > #include > +#include > #include > > #include "internal.h" > @@ -38,6 +39,16 @@ > struct cma cma_areas[MAX_CMA_AREAS]; > unsigned int cma_area_count; > > +bool cma_folio_is_longterm_pinnable(struct folio *folio) > +{ > + /* > + * Explicitly allocated CMA folios own their CMA memory and can be > + * pinned even in ZONE_MOVABLE, as CMA memory cannot be offlined. > + * For now, only HugeTLB tracks these allocations with a folio flag. > + */ > + return folio_test_hugetlb(folio) && folio_test_hugetlb_cma(folio); > +} > + > phys_addr_t cma_get_base(const struct cma *cma) > { > WARN_ON_ONCE(cma->nranges != 1); Thanks. Reviewed-by: David Hildenbrand (Arm) This can go through Andrew's tree with the other hugetlb stuff. -- Cheers, David