From: Dmitry Osipenko <digetx@gmail.com>
To: Alexandre Courbot <gnurou@gmail.com>
Cc: Thierry Reding <thierry.reding@gmail.com>,
Stephen Warren <swarren@wwwdotorg.org>,
Marc Dietrich <marvin24@gmx.de>,
Mika Westerberg <mika.westerberg@linux.intel.com>,
"Rafael J. Wysocki" <rafael.j.wysocki@intel.com>,
Stable <stable@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-tegra@vger.kernel.org" <linux-tegra@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] ARM: tegra: paz00: set gpiod_lookup table conn_id's
Date: Tue, 30 Jun 2015 16:56:54 +0300 [thread overview]
Message-ID: <5592A026.3010200@gmail.com> (raw)
In-Reply-To: <CAAVeFuKcaz1C9OV26+8A+LypScqDcufR+X99KDJwVui39Nq7xA@mail.gmail.com>
30.06.2015 16:42, Alexandre Courbot пишет:
> On Mon, Jun 29, 2015 at 4:34 AM, Dmitry Osipenko <digetx@gmail.com> wrote:
>> Commit 72daceb9a10a ("net: rfkill: gpio: Add default GPIO driver mappings
>> for ACPI") removed possibility to request GPIO by table index for non-ACPI
>> platforms without changing it users. As result "shutdown" GPIO request
>> will fail if request for "reset" GPIO succeeded or "reset" will be
>> requested instead of "shutdown" if "reset" wasn't defined. Fix it by
>> setting conn_id's in gpiod_lookup_table.
>
> Yep, and using con_ids is a good idea anyway.
>
> Acked-by: Alexandre Courbot <acourbot@nvidia.com>
>
After discussion on irc, turned out that patch missed
s/GPIO_LOOKUP_IDX/GPIO_LOOKUP. I'll send V2.
And s/conn_id/con_id typo started to annoy me...
--
Dmitry
prev parent reply other threads:[~2015-06-30 13:58 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-28 19:34 [PATCH] ARM: tegra: paz00: set gpiod_lookup table conn_id's Dmitry Osipenko
2015-06-30 13:42 ` Alexandre Courbot
2015-06-30 13:56 ` Dmitry Osipenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5592A026.3010200@gmail.com \
--to=digetx@gmail.com \
--cc=gnurou@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=marvin24@gmx.de \
--cc=mika.westerberg@linux.intel.com \
--cc=rafael.j.wysocki@intel.com \
--cc=stable@vger.kernel.org \
--cc=swarren@wwwdotorg.org \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).