From: Brian King <brking@linux.vnet.ibm.com>
To: "Martin K. Petersen" <martin.petersen@oracle.com>
Cc: James.Bottomley@HansenPartnership.com,
linux-scsi@vger.kernel.org, stable@vger.kernel.org,
krisman@linux.vnet.ibm.com, wenxiong@linux.vnet.ibm.com
Subject: Re: [PATCH 1/3] [RESEND] ipr: Fix locking for unit attention handling
Date: Fri, 17 Jul 2015 08:02:18 -0500 [thread overview]
Message-ID: <55A8FCDA.9030209@linux.vnet.ibm.com> (raw)
In-Reply-To: <yq1lhefmtp5.fsf@sermon.lab.mkp.net>
On 07/16/2015 08:57 PM, Martin K. Petersen wrote:
>>>>>> "Brian" == Brian King <brking@linux.vnet.ibm.com> writes:
>
> Brian> Make sure we have the host lock held when calling
> Brian> scsi_report_bus_reset. Fixes a crash seen as the __devices list
> Brian> in the scsi host was changing as we were iterating through it.
>
> Nit: I take it that renaming lock_flags to hrrq_flags makes sense. But
> it muddles what is supposed to be a bugfix patch.
>
> Reviewed-by: Martin K. Petersen <martin.petersen@oracle.com>
>
Correct. Thanks for the review.
-Brian
--
Brian King
Power Linux I/O
IBM Linux Technology Center
prev parent reply other threads:[~2015-07-17 13:02 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-14 16:41 [PATCH 1/3] [RESEND] ipr: Fix locking for unit attention handling Brian King
2015-07-17 1:57 ` Martin K. Petersen
2015-07-17 13:02 ` Brian King [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55A8FCDA.9030209@linux.vnet.ibm.com \
--to=brking@linux.vnet.ibm.com \
--cc=James.Bottomley@HansenPartnership.com \
--cc=krisman@linux.vnet.ibm.com \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=stable@vger.kernel.org \
--cc=wenxiong@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).