From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from e18.ny.us.ibm.com ([129.33.205.208]:55552 "EHLO e18.ny.us.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755847AbbGQNCZ (ORCPT ); Fri, 17 Jul 2015 09:02:25 -0400 Received: from /spool/local by e18.ny.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Fri, 17 Jul 2015 09:02:24 -0400 Message-ID: <55A8FCDA.9030209@linux.vnet.ibm.com> Date: Fri, 17 Jul 2015 08:02:18 -0500 From: Brian King MIME-Version: 1.0 To: "Martin K. Petersen" CC: James.Bottomley@HansenPartnership.com, linux-scsi@vger.kernel.org, stable@vger.kernel.org, krisman@linux.vnet.ibm.com, wenxiong@linux.vnet.ibm.com Subject: Re: [PATCH 1/3] [RESEND] ipr: Fix locking for unit attention handling References: <201507141641.t6EGfUKf005602@d03av03.boulder.ibm.com> In-Reply-To: Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: stable-owner@vger.kernel.org List-ID: On 07/16/2015 08:57 PM, Martin K. Petersen wrote: >>>>>> "Brian" == Brian King writes: > > Brian> Make sure we have the host lock held when calling > Brian> scsi_report_bus_reset. Fixes a crash seen as the __devices list > Brian> in the scsi host was changing as we were iterating through it. > > Nit: I take it that renaming lock_flags to hrrq_flags makes sense. But > it muddles what is supposed to be a bugfix patch. > > Reviewed-by: Martin K. Petersen > Correct. Thanks for the review. -Brian -- Brian King Power Linux I/O IBM Linux Technology Center