* [PATCH v2 1/2] ARM: EXYNOS: pd: fix potentian kfree() of ro memory [not found] <1438301390-7397-1-git-send-email-vz@mleia.com> @ 2015-07-31 0:09 ` Vladimir Zapolskiy 2015-07-31 0:38 ` Krzysztof Kozlowski 0 siblings, 1 reply; 2+ messages in thread From: Vladimir Zapolskiy @ 2015-07-31 0:09 UTC (permalink / raw) To: Kukjin Kim, Krzysztof Kozlowski Cc: Russell King, Marek Szyprowski, linux-arm-kernel, linux-samsung-soc, stable The change fixes a bug introduced by 2be2a3ff42a5, memory allocated by kstrdup_const() must be always deallocated with kfree_const(), otherwise there is a risk of kfree'ing ro memory. Signed-off-by: Vladimir Zapolskiy <vz@mleia.com> Cc: <stable@vger.kernel.org> Fixes: 2be2a3ff42a5 ("ARM: EXYNOS: register power domain driver from core_initcall") --- Changes from v1 to v2: * split a single change v1 into two * added Fixes tag and Cc: <stable@vger.kernel.org> arch/arm/mach-exynos/pm_domains.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm/mach-exynos/pm_domains.c b/arch/arm/mach-exynos/pm_domains.c index 6001f1c..5121baa 100644 --- a/arch/arm/mach-exynos/pm_domains.c +++ b/arch/arm/mach-exynos/pm_domains.c @@ -146,7 +146,7 @@ static __init int exynos4_pm_init_power_domain(void) pd->base = of_iomap(np, 0); if (!pd->base) { pr_warn("%s: failed to map memory\n", __func__); - kfree(pd->pd.name); + kfree_const(pd->pd.name); kfree(pd); of_node_put(np); continue; -- 2.1.4 ^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH v2 1/2] ARM: EXYNOS: pd: fix potentian kfree() of ro memory 2015-07-31 0:09 ` [PATCH v2 1/2] ARM: EXYNOS: pd: fix potentian kfree() of ro memory Vladimir Zapolskiy @ 2015-07-31 0:38 ` Krzysztof Kozlowski 0 siblings, 0 replies; 2+ messages in thread From: Krzysztof Kozlowski @ 2015-07-31 0:38 UTC (permalink / raw) To: Vladimir Zapolskiy, Kukjin Kim Cc: Russell King, Marek Szyprowski, linux-arm-kernel, linux-samsung-soc, stable On 31.07.2015 09:09, Vladimir Zapolskiy wrote: > The change fixes a bug introduced by 2be2a3ff42a5, memory allocated > by kstrdup_const() must be always deallocated with kfree_const(), > otherwise there is a risk of kfree'ing ro memory. > > Signed-off-by: Vladimir Zapolskiy <vz@mleia.com> > Cc: <stable@vger.kernel.org> > Fixes: 2be2a3ff42a5 ("ARM: EXYNOS: register power domain driver from core_initcall") > --- > Changes from v1 to v2: > * split a single change v1 into two > * added Fixes tag and Cc: <stable@vger.kernel.org> > > arch/arm/mach-exynos/pm_domains.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Krzysztof Kozlowski <k.kozlowski@samsung.com> Best regards, Krzysztof ^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-07-31 0:38 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <1438301390-7397-1-git-send-email-vz@mleia.com>
2015-07-31 0:09 ` [PATCH v2 1/2] ARM: EXYNOS: pd: fix potentian kfree() of ro memory Vladimir Zapolskiy
2015-07-31 0:38 ` Krzysztof Kozlowski
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).