From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wi0-f174.google.com ([209.85.212.174]:36168 "EHLO mail-wi0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753583AbbHHGMw (ORCPT ); Sat, 8 Aug 2015 02:12:52 -0400 Received: by wicgj17 with SMTP id gj17so83395764wic.1 for ; Fri, 07 Aug 2015 23:12:51 -0700 (PDT) Message-ID: <55C59DDE.5020908@gmail.com> Date: Sat, 08 Aug 2015 08:12:46 +0200 From: Dirk Behme MIME-Version: 1.0 To: Zefan Li CC: stable Subject: 3.4.106: futex: Wrong back port of 9e9aab5dbf? Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Sender: stable-owner@vger.kernel.org List-ID: Hello, from a private -stable review we think that the commit 9e9aab5dbf ("futex: Ensure get_futex_key_refs() always implies a barrier" [1]) is not correctly back ported to 3.4.x: The issue is that the memory barrier is introduced into drop_futex_key_refs() function instead of get_futex_key_refs() function. Additionally, we are unsure if the futex commits this commit is fixing are really in < 3.4.106. I.e. we are unsure if this fix is needed at all. Or at least if some additional futex commits are needed. Do you like to check? Best regards Dirk [1] https://git.kernel.org/cgit/linux/kernel/git/stable/linux-stable.git/commit/?id=9e9aab5dbf6f13478cd996692ed9679af2404fc7