From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <stable-owner@vger.kernel.org>
Received: from aserp1040.oracle.com ([141.146.126.69]:32566 "EHLO
	aserp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1751833AbbHXSq6 (ORCPT
	<rfc822;stable@vger.kernel.org>); Mon, 24 Aug 2015 14:46:58 -0400
Message-ID: <55DB669D.5080501@oracle.com>
Date: Mon, 24 Aug 2015 14:46:53 -0400
From: Sasha Levin <sasha.levin@oracle.com>
MIME-Version: 1.0
To: Kevin Hilman <khilman@kernel.org>, stable@vger.kernel.org
Subject: Re: [PATCH stable/3.18.y] media: remove unused variable that causes
 a warning
References: <1440439336-13326-1-git-send-email-khilman@kernel.org>
In-Reply-To: <1440439336-13326-1-git-send-email-khilman@kernel.org>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
Sender: stable-owner@vger.kernel.org
List-ID: <stable.vger.kernel.org>

On 08/24/2015 02:02 PM, Kevin Hilman wrote:
> From: Linus Torvalds <torvalds@linux-foundation.org>
> 
> My 'allmodconfig' build is _almost_ free of warnings, and most of the
> remaining ones are for legacy drivers that just do bad things that I
> can't find it in my black heart to care too much about.  But this one
> was just annoying me:
> 
>    drivers/media/v4l2-core/videobuf2-core.c:3256:26: warning: unused variable ‘fileio’ [-Wunused-variable]
> 
> because commit 0e661006370b ("[media] vb2: fix 'UNBALANCED' warnings
> when calling vb2_thread_stop()") removed all users of 'fileio' and
> instead calls "__vb2_cleanup_fileio(q)" to clean up q->fileio.  But the
> now unused 'fileio' variable was left around.
> 
> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
> (cherry picked from commit 1d11437f4fd02f9b5d3749675a1232216787dcc6)
> Cc: <stable@vger.kernel.org> # v3.18+
> Signed-off-by: Kevin Hilman <khilman@linaro.org>

Hey Kevin,

I'm afraid this isn't -stable material: it doesn't fix and actual problem
that bothers users, so I can't take it.


Thanks,
Sasha