From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Message-ID: <55DCC35A.3000404@posteo.de> Date: Tue, 25 Aug 2015 21:34:50 +0200 From: Martin Kepplinger MIME-Version: 1.0 To: gregkh@linuxfoundation.org, Stable@vger.kernel.org, christoph.muellner@theobroma-systems.com, jic23@kernel.org, martin.kepplinger@theobroma-systems.com Subject: Re: FAILED: patch "[PATCH] iio: mma8452: use iio event type IIO_EV_TYPE_MAG" failed to apply to 4.1-stable tree References: <143906771171206@kroah.com> In-Reply-To: <143906771171206@kroah.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 8bit Sender: stable-owner@vger.kernel.org List-ID: Am 2015-08-08 um 23:01 schrieb gregkh@linuxfoundation.org: > > The patch below does not apply to the 4.1-stable tree. > If someone wants it applied there, or to any other stable or longterm > tree, then please email the backport, including the original git commit > id to . The affected code hasn't been in mainline for 4.1 and older, therefore the problem doesn't exist. > > thanks, > > greg k-h > > ------------------ original commit in Linus's tree ------------------ > > From c5d0db0690ff0a963dc082e7645268c466bf9a84 Mon Sep 17 00:00:00 2001 > From: Martin Kepplinger > Date: Sun, 5 Jul 2015 19:50:18 +0200 > Subject: [PATCH] iio: mma8452: use iio event type IIO_EV_TYPE_MAG > > IIO_EV_TYPE_THRESH in rising direction describes an event where the > threshold is crossed in rising direction, positive or negative values > being possible. This is not the case here. > > Since the threshold is no signed value and only the magnitude is compared, > IIO_EV_TYPE_MAG is what describes the behaviour of these devices, see the > sysfs-bus-iio ABI Documentation. > > Signed-off-by: Martin Kepplinger > Signed-off-by: Christoph Muellner > Cc: > Signed-off-by: Jonathan Cameron > > diff --git a/drivers/iio/accel/mma8452.c b/drivers/iio/accel/mma8452.c > index e8e2077c7244..13ea1ea23328 100644 > --- a/drivers/iio/accel/mma8452.c > +++ b/drivers/iio/accel/mma8452.c > @@ -557,21 +557,21 @@ static void mma8452_transient_interrupt(struct iio_dev *indio_dev) > if (src & MMA8452_TRANSIENT_SRC_XTRANSE) > iio_push_event(indio_dev, > IIO_MOD_EVENT_CODE(IIO_ACCEL, 0, IIO_MOD_X, > - IIO_EV_TYPE_THRESH, > + IIO_EV_TYPE_MAG, > IIO_EV_DIR_RISING), > ts); > > if (src & MMA8452_TRANSIENT_SRC_YTRANSE) > iio_push_event(indio_dev, > IIO_MOD_EVENT_CODE(IIO_ACCEL, 0, IIO_MOD_Y, > - IIO_EV_TYPE_THRESH, > + IIO_EV_TYPE_MAG, > IIO_EV_DIR_RISING), > ts); > > if (src & MMA8452_TRANSIENT_SRC_ZTRANSE) > iio_push_event(indio_dev, > IIO_MOD_EVENT_CODE(IIO_ACCEL, 0, IIO_MOD_Z, > - IIO_EV_TYPE_THRESH, > + IIO_EV_TYPE_MAG, > IIO_EV_DIR_RISING), > ts); > } > @@ -644,7 +644,7 @@ static int mma8452_reg_access_dbg(struct iio_dev *indio_dev, > > static const struct iio_event_spec mma8452_transient_event[] = { > { > - .type = IIO_EV_TYPE_THRESH, > + .type = IIO_EV_TYPE_MAG, > .dir = IIO_EV_DIR_RISING, > .mask_separate = BIT(IIO_EV_INFO_ENABLE), > .mask_shared_by_type = BIT(IIO_EV_INFO_VALUE) | >